Slaves file is now a template. #2549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
Jenkins, test this please. Good catch. I agree, we should just drop this from the distribution. |
Contributor
|
LGTM pending tests. |
|
QA tests have started for PR 2549 at commit
|
|
QA tests have finished for PR 2549 at commit
|
|
Test PASSed. |
Contributor
|
Merging in master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 0dc868e removed the
conf/slavesfile and made it a template like most of the other configuration files. This means you can no longer runmake-distribution.shunless you manually create a slaves file to be statically bundled in your distribution, which seems at odds with making it a template file.