Skip to content

[SPARK-3707] [SQL] Fix bug of type coercion in DIV #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chenghao-intel wants to merge 2 commits into from
Closed

[SPARK-3707] [SQL] Fix bug of type coercion in DIV #2559

chenghao-intel wants to merge 2 commits into from

Conversation

@chenghao-intel
Copy link
Contributor

@chenghao-intel chenghao-intel commented Sep 27, 2014

Calling BinaryArithmetic.dataType will throws exception until it's resolved, but in type coercion rule Division, seems doesn't follow this.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have started for PR 2559 at commit 199a85d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

Tests timed out after a configured wait of 120m.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 27, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20917/

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have started for PR 2559 at commit 199a85d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

Tests timed out after a configured wait of 120m.

@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Sep 28, 2014

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 28, 2014

QA tests have started for PR 2559 at commit 199a85d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 28, 2014

Tests timed out after a configured wait of 120m.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 28, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20936/

@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Sep 30, 2014

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2559 at commit 199a85d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2559 at commit 199a85d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 30, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21018/

adrian-wang
adrian-wang reviewed Sep 30, 2014
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
Copy link
Contributor

@adrian-wang adrian-wang Sep 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing this line? this could give more information

Copy link
Contributor Author

@chenghao-intel chenghao-intel Oct 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this, I have reverted it.

Copy link
Contributor Author

@chenghao-intel chenghao-intel Oct 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we couldn't revert this, seems it leads a compiling error.

Copy link
Contributor

@marmbrus marmbrus Oct 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note it looks like importing dsl.expressions._ is the cause as it also uses ===.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2559 at commit d1c553f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2559 at commit d1c553f.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 1, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21096/

@marmbrus
Copy link
Contributor

marmbrus commented Oct 1, 2014

Looks like the failure is a legitimate compilation problem.

@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Oct 8, 2014

retest this please.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 2559 at commit 199a85d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have finished for PR 2559 at commit 199a85d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 8, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21439/Test PASSed.

@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Oct 9, 2014

@marmbrus any more comments on this?

@marmbrus
Copy link
Contributor

marmbrus commented Oct 9, 2014

Thanks, I've merged this to master.

@asfgit asfgit closed this in 4ec9319 Oct 9, 2014
@chenghao-intel chenghao-intel deleted the type_coercion branch October 9, 2014 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chenghao-intel @SparkQA @AmplabJenkins @marmbrus @adrian-wang