-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28809][DOC][SQL]Document SHOW TABLE in SQL Reference #25632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dilipbiswal @gatorsmile |
|
@gatorsmile Can you please look at the attached screen shot ? The output kind of scrolls and does not look as pretty ? Any advice on how we should display this ? |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm not concerned about the long table display)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back-tick quote SHOW TABLE EXTENDED?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"for the table name"
"is present. It will output"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file-system-specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a full regex? we should say a little more about what's allowed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the details
|
@shivusondur are you able to update? |
4242185 to
b81aaf2
Compare
shivusondur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowen
I handled all your comments, please check
| `Created By`, `Type`, `Provider`, `Table Properties`, `Location`, `Serde Library`, `InputFormat`, | ||
| `OutputFormat`, `Storage Properties`, `Partition Provider`, `Partition Columns` and `Schema`. | ||
|
|
||
| Users cannot use regular expression for the table name if a partition specification is present. It will output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit: a regular expression. But how about:
"If a partition specification is present, it outputs the given partition's ... Note that a table regex cannot be used with a partition specification."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowen
If the PARTITION key present in the query, the pattern mentioned in LIKE will not be treated as a regex. It will be treated as normal name.
for example. If we mention the regex with LIKE and PARTITION keyword, it fails like below.

But if mention the full name like below it works

Is it better to mention this exception scenario in the examples section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that agrees with the text I suggested? there's no problem documenting this in the docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowen
Documented Exception scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I don't think you changed this sentence. I'm suggesting a typo fix and rewrite right here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivusondur still at least one more change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowen
Sorry for late, I updated it according to your suggestion.
|
Test build #4915 has finished for PR 25632 at commit
|
|
Merged to master |
What changes were proposed in this pull request?
Added the document reference for SHOW TABLE EXTENDED sql command
Why are the changes needed?
For User reference
Does this PR introduce any user-facing change?
yes, it provides document reference for SHOW TABLE EXTENDED sql command
How was this patch tested?
verified in snap
Attached the Snap