Skip to content

[SPARK-19926][PYSPARK] make captured exception from JVM side user friendly #25814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
advancedxy wants to merge 4 commits into from
Closed

[SPARK-19926][PYSPARK] make captured exception from JVM side user friendly #25814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ff3ea4
[SPARK-19926][PYSPARK] make captured exception from JVM side user fri…
advancedxy Sep 17, 2019
02988b1
Address comments
advancedxy Sep 18, 2019
3c028e9
Remove unused imports
advancedxy Sep 18, 2019
9e4e7e9
Fix imports
advancedxy Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/pyspark/sql/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# -*- encoding: utf-8 -*-
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
Expand Down Expand Up @@ -26,6 +27,12 @@ def test_capture_analysis_exception(self):
self.assertRaises(AnalysisException, lambda: self.spark.sql("select abc"))
self.assertRaises(AnalysisException, lambda: self.df.selectExpr("a + b"))

def test_capture_user_friendly_exception(self):
try:
self.spark.sql("select `中文字段`")
except AnalysisException as e:
self.assertRegexpMatches(str(e), "cannot resolve '`中文字段`'")

def test_capture_parse_exception(self):
self.assertRaises(ParseException, lambda: self.spark.sql("abc"))

Expand Down
8 changes: 7 additions & 1 deletion python/pyspark/sql/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#

import py4j
import sys


class CapturedException(Exception):
Expand All @@ -25,7 +26,12 @@ def __init__(self, desc, stackTrace, cause=None):
self.cause = convert_exception(cause) if cause is not None else None

def __str__(self):
return repr(self.desc)
desc = self.desc
# encode unicode instance for python2 for human readable description
if sys.version_info.major < 3 and isinstance(desc, unicode):
return str(desc.encode('utf-8'))
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this once we drop Python 2, which will be right away after Spark 3.0 release.

Copy link
Contributor Author

@advancedxy advancedxy Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

else:
return str(desc)


class AnalysisException(CapturedException):
Expand Down