[SPARK-28962][SPARK-27297][SQL] Add overload for filter with index to functions object #26007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
approved these changes
Oct 3, 2019
Member
ueshin
left a comment
ueshin
left a comment
There was a problem hiding this comment.
LGTM, pending tests.
Could you add tags to the PR title? [SPARK-28962][SPARK-27297][SQL] should be fine.
nvander1
changed the title
Contributor
Author
|
Sure thing! |
|
Test build #111707 has finished for PR 26007 at commit
|
Member
|
Thanks! merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add an overload for the higher order function
filterthat takes array index as its second argument toorg.apache.spark.sql.functions.Why are the changes needed?
See: SPARK-28962 and SPARK-27297. Specifically @ueshin pointing out the discrepency here: #24232 (comment)
Does this PR introduce any user-facing change?
How was this patch tested?
Updated the these test suites:
test.org.apache.spark.sql.JavaHigherOrderFunctionsSuiteand
org.apache.spark.sql.DataFrameFunctionsSuite