[SPARK-29189][FOLLOW-UP][SQL] Beautify config name #26054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
|
Test build #111888 has finished for PR 26054 at commit
|
|
Test build #4894 has finished for PR 26054 at commit
|
Member
|
cc @squito |
Member
|
retest this please |
HyukjinKwon
approved these changes
Oct 8, 2019
cloud-fan
approved these changes
Oct 8, 2019
|
Test build #111906 has finished for PR 26054 at commit
|
dongjoon-hyun
approved these changes
Oct 8, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master. Thank you all!
atronchi
pushed a commit
to atronchi/spark
that referenced
this pull request
Oct 23, 2019
### What changes were proposed in this pull request? Beautify comment ### Why are the changes needed? The config name now is pretty weird. ### Does this PR introduce any user-facing change? No ### How was this patch tested? No test. Closes apache#26054 from wangshisan/SPARK-29189. Authored-by: gwang3 <gwang3@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Beautify comment
Why are the changes needed?
The config name now is pretty weird.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No test.