-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29107][SQL][TESTS] Port window.sql (Part 1) #26119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
|
ok to test |
|
Thank you, @DylanGuedes ! |
|
Test build #112081 has finished for PR 26119 at commit
|
|
@DylanGuedes Thanks for the work. |
|
#26107 is merged. Thanks, @gengliangwang . |
|
Retest this please. |
|
Test build #112123 has finished for PR 26119 at commit
|
|
According to the failures, we need to update the PR. |
|
@dongjoon-hyun should I JIRA that? |
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
|
Test build #112130 has finished for PR 26119 at commit
|
|
@DylanGuedes, please skip or fix the tests being failed in the thrift server. cc @wangyum |
|
@HyukjinKwon I have no idea why they are breaking on Thrift, they used to pass in the older PR and they also were fine in my local config (I can't rerun then now because my environment suddenly broken). Do you have any suggestion? I don't think that makes sense to just comment out anything related to date since |
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
|
Test build #112420 has finished for PR 26119 at commit
|
|
You can either skip the single test with a comment or add it in a blacklist I think cc @wangyum |
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I will merge in few days.
|
Test build #112422 has finished for PR 26119 at commit
|
|
Merged to master. |
|
Thanks for the work, @DylanGuedes! btw, how many PR parts are left for window.sql? It seems we have no open PRs for this. |
|
@maropu Two parts are missing. I thought that there were more people interested on working on them because I read some comments on JIRA, but since no one opened a MR, I'll create a new one for the other parts and work them as well. |
|
Thanks, again! |
What changes were proposed in this pull request?
This PR ports window.sql from PostgreSQL regression tests https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/sql/window.sql from lines 1~319
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/window.out
Why are the changes needed?
To ensure compatibility with PostgreSQL.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins. And, Comparison with PgSQL results.