-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29654][CORE] Add configuration to allow disabling registration of static sources to the metrics system #26320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LucaCanali
wants to merge
5
commits into
apache:master
from
LucaCanali:addConfigRegisterStaticMetrics
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
57c713f
Add configuration to disable registration of static sources to the me…
LucaCanali 7e9e8bb
Address review comments.
LucaCanali 5554489
Corrected mistake in the config parameter name.
LucaCanali 1a03124
Add tests for static sources registration
LucaCanali 564ec07
Review comments.
LucaCanali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
core/src/test/scala/org/apache/spark/metrics/source/SourceConfigSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.metrics.source | ||
|
|
||
| import org.apache.spark.{LocalSparkContext, SparkConf, SparkContext, SparkFunSuite} | ||
| import org.apache.spark.internal.config.METRICS_STATIC_SOURCES_ENABLED | ||
|
|
||
| class SourceConfigSuite extends SparkFunSuite with LocalSparkContext { | ||
|
|
||
| test("Test configuration for adding static sources registration") { | ||
| val conf = new SparkConf() | ||
| conf.set(METRICS_STATIC_SOURCES_ENABLED, true) | ||
| val sc = new SparkContext("local", "test", conf) | ||
| try { | ||
| val metricsSystem = sc.env.metricsSystem | ||
|
|
||
| // Static sources should be registered | ||
| assert (metricsSystem.getSourcesByName("CodeGenerator").nonEmpty) | ||
| assert (metricsSystem.getSourcesByName("HiveExternalCatalog").nonEmpty) | ||
| } finally { | ||
| sc.stop() | ||
| } | ||
| } | ||
dongjoon-hyun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test("Test configuration for skipping static sources registration") { | ||
| val conf = new SparkConf() | ||
| conf.set(METRICS_STATIC_SOURCES_ENABLED, false) | ||
| val sc = new SparkContext("local", "test", conf) | ||
| try { | ||
| val metricsSystem = sc.env.metricsSystem | ||
|
|
||
| // Static sources should not be registered | ||
| assert (metricsSystem.getSourcesByName("CodeGenerator").isEmpty) | ||
| assert (metricsSystem.getSourcesByName("HiveExternalCatalog").isEmpty) | ||
| } finally { | ||
| sc.stop() | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why they are static and the others are not static?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache Spark defines like the following.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spark.metrics.staticSources.enabledmight look better. Using static as the name space looks weird. cc @cloud-fan @Ngone51There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
staticSourcessounds better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that staticsSources sounds better.
BTW there is probably room for a naming convention for the "switch parameters" for enabling/disabling metrics? Currently we have:
spark.metrics.static.sources.enabledspark.app.status.metrics.enabledspark.sql.streaming.metricsEnabledThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #26692