[SPARK-29653][SQL] Fix MICROS_PER_MONTH in IntervalUtils #26321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #112912 has finished for PR 26321 at commit
|
cloud-fan
approved these changes
Oct 30, 2019
MaxGekk
approved these changes
Oct 30, 2019
| struct<date_part('epoch', t2.`c`):decimal(18,6)> | ||
| -- !query 106 output | ||
| 31873892788.332003 | ||
| 31897220765.004003 |
Member
There was a problem hiding this comment.
I have compared to PostgreSQL output:
maxim=# select date_part('epoch', interval '1010 year 9 month 8 day 7 hour 6 minute 5 second 4 millisecond 3 microseconds');
date_part
-----------------
31897220765.004
(1 row)It seems PostgreSQL just looses the precision.
|
Test build #112913 has finished for PR 26321 at commit
|
|
Test build #112915 has finished for PR 26321 at commit
|
dongjoon-hyun
approved these changes
Oct 30, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you all.
Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MICROS_PER_MONTH = DAYS_PER_MONTH * MICROS_PER_DAY
Why are the changes needed?
fix bug
Does this PR introduce any user-facing change?
no
How was this patch tested?
add ut