-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29696][SQL][TESTS] Port groupingsets.sql #26352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Test build #113067 has finished for PR 26352 at commit
|
|
Test build #113071 has finished for PR 26352 at commit
|
|
Retest this please. |
|
Thank you for working on this, @maropu ! |
|
Test build #113222 has finished for PR 26352 at commit
|
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/groupingsets.sql
Show resolved
Hide resolved
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/groupingsets.sql
Outdated
Show resolved
Hide resolved
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/groupingsets.sql
Show resolved
Hide resolved
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/groupingsets.sql
Outdated
Show resolved
Hide resolved
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (except a few minor comments.)
For SPARK-19842, it's okay if that means something I missed.
|
The last is moving comments only, and I also locally rebuilt and confirmed that the output result file is not changed. Merged to master~ |
|
Now, do we have only two your PRs to complete the umbrella? |
|
My two PRs ( |
|
Got it~ |
|
Test build #113230 has finished for PR 26352 at commit
|
What changes were proposed in this pull request?
This PR ports groupingsets.sql from PostgreSQL regression tests https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/sql/groupingsets.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/groupingsets.out
Why are the changes needed?
To check behaviour differences between Spark and PostgreSQL
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins. And, Comparison with PgSQL results