Skip to content

Conversation

@maropu
Copy link
Member

@maropu maropu commented Nov 1, 2019

What changes were proposed in this pull request?

This PR ports groupingsets.sql from PostgreSQL regression tests https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/sql/groupingsets.sql

The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/groupingsets.out

Why are the changes needed?

To check behaviour differences between Spark and PostgreSQL

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass the Jenkins. And, Comparison with PgSQL results

@maropu
Copy link
Member Author

maropu commented Nov 1, 2019

WIP cuz I've not filed issues in jira.

@maropu maropu changed the title [WIP][SPARK-29696][SQL][TESTS] Port groupingsets.sql [SPARK-29696][SQL][TESTS] Port groupingsets.sql Nov 1, 2019
@SparkQA
Copy link

SparkQA commented Nov 1, 2019

Test build #113067 has finished for PR 26352 at commit 6e733fe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 1, 2019

Test build #113071 has finished for PR 26352 at commit 94b7e79.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@dongjoon-hyun
Copy link
Member

Thank you for working on this, @maropu !
cc @gatorsmile

@SparkQA
Copy link

SparkQA commented Nov 4, 2019

Test build #113222 has finished for PR 26352 at commit 94b7e79.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (except a few minor comments.)
For SPARK-19842, it's okay if that means something I missed.

@dongjoon-hyun
Copy link
Member

The last is moving comments only, and I also locally rebuilt and confirmed that the output result file is not changed. Merged to master~

@dongjoon-hyun
Copy link
Member

Now, do we have only two your PRs to complete the umbrella?

@maropu
Copy link
Member Author

maropu commented Nov 5, 2019

My two PRs (insert.sql and limit.sql) + two more tests for create_table.sql and alter_table.sql. I'm currently checking the latter two files now.

@dongjoon-hyun
Copy link
Member

Got it~

@SparkQA
Copy link

SparkQA commented Nov 5, 2019

Test build #113230 has finished for PR 26352 at commit d7f6909.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants