[SPARK-29722][SQL] Non reversed keywords should be able to be used in high order functions #26366
Conversation
… high order functions
|
cc @ueshin @gatorsmile @cloud-fan @HyukjinKwon @dongjoon-hyun, thanks in advance. |
|
Test build #113126 has finished for PR 26366 at commit
|
|
retest this please |
|
Test build #113133 has finished for PR 26366 at commit
|
|
retest this please |
| | IDENTIFIER '->' expression #lambda | ||
| | '(' IDENTIFIER (',' IDENTIFIER)+ ')' '->' expression #lambda | ||
| | identifier '->' expression #lambda | ||
| | '(' identifier (',' identifier)+ ')' '->' expression #lambda |
There was a problem hiding this comment.
Ur, I see. Looks reasonable to me.
| -- Transform an array with index | ||
| select transform(ys, (y, i) -> y + i) as v from nested; | ||
| -- use non reversed keywords | ||
| select transform(ys, (cost, i) -> cost + i) as v from nested; |
There was a problem hiding this comment.
Can you move the two tests above into the end of the file to make diff smaller in sq.out.
There was a problem hiding this comment.
Also, can you add some tests for error cases if ansi=true?
There was a problem hiding this comment.
thanks for you suggestion. I just moved them to the end of this file, and add some cases to verify with ansi flag.
|
Test build #113148 has finished for PR 26366 at commit
|
|
Test build #113163 has finished for PR 26366 at commit
|
|
Merged to master. |
5 participants
What changes were proposed in this pull request?
Support non-reversed keywords to be used in high order functions.
Why are the changes needed?
the keywords are non-reversed.
Does this PR introduce any user-facing change?
yes, all non-reversed keywords can be used in high order function correctly
How was this patch tested?
add uts