-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29671][SQL] Simplify string representation of intervals #26367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ping @cloud-fan @dongjoon-hyun |
|
Test build #113127 has finished for PR 26367 at commit
|
|
Test build #113130 has finished for PR 26367 at commit
|
|
jenkins, retest this, please |
|
Test build #113157 has finished for PR 26367 at commit
|
|
jenkins, retest this, please |
|
Test build #113167 has finished for PR 26367 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @MaxGekk , @cloud-fan , @maropu .
This looks really nicer.
Merged to master.
What changes were proposed in this pull request?
In the PR, I propose to changed
CalendarInterval.toString:weekunitmillisecondsandmicrosecondsas the fractional part of thesecondsunit.Why are the changes needed?
To improve readability.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
CalendarIntervalSuiteandIntervalUtilsSuiteliterals.sql,datetime.sqlandinterval.sql