Skip to content

Conversation

@shahidki31
Copy link
Contributor

@shahidki31 shahidki31 commented Nov 2, 2019

What changes were proposed in this pull request?

Support KVStore, HiveThriftServer2AppStatusStore for HiveThriftServer2Listener.

Why are the changes needed?

Currently Historyserver cannot display JDBC/ODBC tab in the WebUI when it replays the event log. To get support of Historyserver, we need to create a KVstore for storing processed events and there by display in the UI from the store. This PR support storing live events in a status store. Also the PR is prerequisite for the Jira SPARK-29724

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT and Manual tests.

Screenshot 2019-11-03 at 3 07 36 AM

@SparkQA
Copy link

SparkQA commented Nov 2, 2019

Test build #113139 has finished for PR 26372 at commit d928032.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class HiveThriftServer2AppStatusStore(

@shahidki31
Copy link
Contributor Author

cc @srowen, @vanzin, @wangyum Kindly review. This PR may be a prerequisite for Historyserver support for JDBC/ODBC tab in WebUI. Thanks

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113140 has finished for PR 26372 at commit 9acad5b.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about this to have an opinion.

@shahidki31
Copy link
Contributor Author

shahidki31 commented Nov 3, 2019

I am closing this PR in favour of #26378 , which contains both Support for History server as well as AppStatus store for HiveThriftserver listener, including refactoring of the listener.

@shahidki31 shahidki31 closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants