-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29729][BUILD] Upgrade ASM to 7.2 #26373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #113142 has finished for PR 26373 at commit
|
|
retest this please |
|
Test build #113147 has finished for PR 26373 at commit
|
|
This passed all UTs twice successfully except the CRAN check. |
|
Yea, I've also checked all the unit tests passed except for that. |
|
Retest this please. |
|
Test build #113152 has finished for PR 26373 at commit
|
|
Retest this please |
|
Test build #113154 has finished for PR 26373 at commit
|
|
Retest this please |
|
The one PySpark failure seems to be irrelevant. |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending tests
|
Thank you for review, @srowen ! |
|
Test build #113177 has finished for PR 26373 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged to master. Thank you!
This PR aims to upgrade ASM to 7.2. - https://issues.apache.org/jira/browse/XBEAN-322 (Upgrade to ASM 7.2) - https://asm.ow2.io/versions.html This will bring the following patches. - 317875: Infinite loop when parsing invalid method descriptor - 317873: Add support for RET instruction in AdviceAdapter - 317872: Throw an exception if visitFrame used incorrectly - add support for Java 14 No. Pass the Jenkins with the existing UTs. Closes apache#26373 from dongjoon-hyun/SPARK-29729. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This PR aims to upgrade ASM to 7.2. - https://issues.apache.org/jira/browse/XBEAN-322 (Upgrade to ASM 7.2) - https://asm.ow2.io/versions.html This will bring the following patches. - 317875: Infinite loop when parsing invalid method descriptor - 317873: Add support for RET instruction in AdviceAdapter - 317872: Throw an exception if visitFrame used incorrectly - add support for Java 14 No. Pass the Jenkins with the existing UTs. Closes apache#26373 from dongjoon-hyun/SPARK-29729. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
This PR aims to upgrade ASM to 7.2.
Why are the changes needed?
This will bring the following patches.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with the existing UTs.