Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 2, 2019

What changes were proposed in this pull request?

This PR aims to upgrade ASM to 7.2.

Why are the changes needed?

This will bring the following patches.

  • 317875: Infinite loop when parsing invalid method descriptor
  • 317873: Add support for RET instruction in AdviceAdapter
  • 317872: Throw an exception if visitFrame used incorrectly
  • add support for Java 14

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with the existing UTs.

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113142 has finished for PR 26373 at commit 4076e42.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Nov 3, 2019

retest this please

@dongjoon-hyun
Copy link
Member Author

Thank you for retriggering, @maropu .
All Jenkins with R testing seems to fail now. (master sbt/branch-2.4 sbt/PRBuilder).

* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) : 
  dims [product 24] do not match the length of object [0]

cc @viirya

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113147 has finished for PR 26373 at commit 4076e42.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

This passed all UTs twice successfully except the CRAN check.

* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) : 
  dims [product 24] do not match the length of object [0]

@maropu
Copy link
Member

maropu commented Nov 3, 2019

Yea, I've also checked all the unit tests passed except for that.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29729][BUILD] Upgrade ASM to 7.2 [SPARK-29729][BUILD][test-hadoop3.2][test-java11] Upgrade ASM to 7.2 Nov 3, 2019
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113152 has finished for PR 26373 at commit 4076e42.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113154 has finished for PR 26373 at commit 4076e42.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please

@dongjoon-hyun
Copy link
Member Author

The one PySpark failure seems to be irrelevant.

======================================================================
FAIL: test_slice (pyspark.streaming.tests.test_dstream.BasicOperationTests)
Basic operation test for DStream.slice.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/SparkPullRequestBuilder@2/python/pyspark/streaming/tests/test_dstream.py", line 101, in test_slice
    self.assertEqual(set([1]), set(get_sliced(0, 0)))
AssertionError: Items in the first set but not the second:

----------------------------------------------------------------------

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @srowen !

@SparkQA
Copy link

SparkQA commented Nov 3, 2019

Test build #113177 has finished for PR 26373 at commit 4076e42.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29729][BUILD][test-hadoop3.2][test-java11] Upgrade ASM to 7.2 [SPARK-29729][BUILD] Upgrade ASM to 7.2 Nov 3, 2019
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged to master. Thank you!

@dongjoon-hyun dongjoon-hyun deleted the SPARK-29729 branch November 3, 2019 18:43
rshkv pushed a commit to palantir/spark that referenced this pull request Jun 24, 2020
This PR aims to upgrade ASM to 7.2.
- https://issues.apache.org/jira/browse/XBEAN-322 (Upgrade to ASM 7.2)
- https://asm.ow2.io/versions.html

This will bring the following patches.
- 317875: Infinite loop when parsing invalid method descriptor
- 317873: Add support for RET instruction in AdviceAdapter
- 317872: Throw an exception if visitFrame used incorrectly
- add support for Java 14

No.

Pass the Jenkins with the existing UTs.

Closes apache#26373 from dongjoon-hyun/SPARK-29729.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
rshkv pushed a commit to palantir/spark that referenced this pull request Jun 25, 2020
This PR aims to upgrade ASM to 7.2.
- https://issues.apache.org/jira/browse/XBEAN-322 (Upgrade to ASM 7.2)
- https://asm.ow2.io/versions.html

This will bring the following patches.
- 317875: Infinite loop when parsing invalid method descriptor
- 317873: Add support for RET instruction in AdviceAdapter
- 317872: Throw an exception if visitFrame used incorrectly
- add support for Java 14

No.

Pass the Jenkins with the existing UTs.

Closes apache#26373 from dongjoon-hyun/SPARK-29729.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants