-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29733][TESTS] Fix wrong order of parameters passed to assertEquals
#26377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #113161 has finished for PR 26377 at commit
|
|
jenkins, retest this, please |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, great fix. Looks good pending tests.
|
Test build #113179 has finished for PR 26377 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertEqualsassertEquals
What changes were proposed in this pull request?
The
assertEqualsmethod of JUnit Assert requires the first parameter to be the expected value. In this PR, I propose to change the order of parameters when the expected value is passed as the second parameter.Why are the changes needed?
Wrong order of assert parameters confuses when the assert fails and the parameters have special string representation. For example:
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing tests.