Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Nov 4, 2019

What changes were proposed in this pull request?

This upgrades joda-time from 2.9 to 2.10.5.

Why are the changes needed?

Joda 2.9 is almost 4 yrs ago and there are bugs fix and tz database updates.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests.

@viirya
Copy link
Member Author

viirya commented Nov 4, 2019

cc @HyukjinKwon @felixcheung @srowen

@dongjoon-hyun
Copy link
Member

Looks fine if the test passes.
Also, cc @MaxGekk

Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which module in Spark depend on it? Can this dependency be removed at all?

@srowen
Copy link
Member

srowen commented Nov 4, 2019

sql/hive has a dependency on it, but I don't see we use it directly? It might be there to manage up the version.

Also, arrow:

[INFO] +- org.apache.arrow:arrow-vector:jar:0.12.0:compile
[INFO] |  +- org.apache.arrow:arrow-format:jar:0.12.0:compile
[INFO] |  +- org.apache.arrow:arrow-memory:jar:0.12.0:compile
[INFO] |  +- joda-time:joda-time:jar:2.9.3:compile

If that's true, seems OK to manage it up further.

@SparkQA
Copy link

SparkQA commented Nov 4, 2019

Test build #113226 has finished for PR 26389 at commit 7bae3cb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@viirya viirya deleted the upgrade-joda branch December 27, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants