Skip to content

[SPARK-29823][MLLIB] Improper persist strategy in mllib.clustering.KMeans.run() #26483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amanomer wants to merge 1 commit into from
Closed

[SPARK-29823][MLLIB] Improper persist strategy in mllib.clustering.KMeans.run() #26483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,12 @@ class KMeans private (

// Compute squared norms and cache them.
val norms = data.map(Vectors.norm(_, 2.0))
Copy link
Contributor Author

@amanomer amanomer Nov 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

norms have only one child zippedData so all actions that rely on norms also rely on zippedData and in runAlgorithm(), multiple actions have been applied on zippedData.

norms.persist()
val zippedData = data.zip(norms).map { case (v, norm) =>
new VectorWithNorm(v, norm)
}
zippedData.persist()
val model = runAlgorithm(zippedData, instr)
norms.unpersist()
zippedData.unpersist()

// Warn at the end of the run as well, for increased visibility.
if (data.getStorageLevel == StorageLevel.NONE) {
Expand Down