-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29873][SQL][Test][FOLLOWUP] set operations should not escape when regen golden file with --SET --import both specified #26557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a854316
[SPARK-29873][SQL] set operations should not escape when regen golden…
yaooqinn c791b36
rm changes in literals.sql
yaooqinn 8fb683e
rm tests
yaooqinn 79d27c6
Merge branch 'master' into SPARK-29873
yaooqinn 538a44f
comments, to upper case
yaooqinn 3192e15
comment
yaooqinn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
sql/core/src/test/resources/sql-tests/inputs/ansi/higher-order-functions.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| --import higher-order-functions.sql | ||
| --IMPORT higher-order-functions.sql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| --- malformed interval literal with ansi mode | ||
| --import literals.sql | ||
| --IMPORT literals.sql |
2 changes: 1 addition & 1 deletion
2
sql/core/src/test/resources/sql-tests/inputs/interval-display-iso_8601.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| -- tests for interval output style with iso_8601 format | ||
| --SET spark.sql.intervalOutputStyle = ISO_8601 | ||
| --import interval-display.sql | ||
| --IMPORT interval-display.sql |
2 changes: 1 addition & 1 deletion
2
sql/core/src/test/resources/sql-tests/inputs/interval-display-sql_standard.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| -- tests for interval output style with sql standard format | ||
| --SET spark.sql.intervalOutputStyle = SQL_STANDARD | ||
| --import interval-display.sql | ||
| --IMPORT interval-display.sql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah seems we have 2 different kinds of settings now:
The second one is pretty useful with
--import. We want to run the same queries with different settings and save the answers.Shall we have different directives for them? @maropu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a second thought, we only expect the
--SETto change behavior if we import queries. So the change here LGTM.@yaooqinn can you update the comment to explain it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW now
--SETis upper case and--importis lower case. Seems better to always use upper case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also cc @wangyum , why do we need
isTestWithConfigSetsfor thriftserver tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will update the comments and change case for
--importThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloud-fan To reduce the test time. The
mvntest often timed out at that time: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-maven-hadoop-2.7/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean setting config is expensive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will run
configSetstimes:spark/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
Lines 287 to 298 in ec5d698
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that's a problem. We should think about how to reduce test time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm late. The change looks reasonable...