[SPARK-29859][SQL] ALTER DATABASE (SET LOCATION) should look up catalog like v2 commands #26562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terNamespaceSetLocationExec to make ALTER DATABASE (SET LOCATION) look up catalog like v2 commands.
Contributor
Author
|
@cloud-fan @imback82 @dongjoon-hyun |
imback82
reviewed
Nov 17, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
Outdated
Show resolved
Hide resolved
Member
|
ok to test |
dongjoon-hyun
changed the title
|
Test build #113963 has finished for PR 26562 at commit
|
cloud-fan
reviewed
Nov 18, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Sorry for too many commits which cause too many builds. Will avoid this going forward. |
cloud-fan
approved these changes
Nov 18, 2019
imback82
reviewed
Nov 18, 2019
...in/scala/org/apache/spark/sql/execution/datasources/v2/AlterNamespaceSetPropertiesExec.scala
Show resolved
Hide resolved
|
Test build #113993 has finished for PR 26562 at commit
|
|
Test build #113984 has finished for PR 26562 at commit
|
|
Test build #113989 has finished for PR 26562 at commit
|
|
Test build #113988 has finished for PR 26562 at commit
|
|
Test build #113986 has finished for PR 26562 at commit
|
Contributor
|
retest this please |
|
Test build #114000 has finished for PR 26562 at commit
|
Contributor
|
thanks, merging to master! |
Contributor
Author
|
thank you all for review and suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add AlterNamespaceSetLocationStatement, AlterNamespaceSetLocation, AlterNamespaceSetLocationExec to make ALTER DATABASE (SET LOCATION) look up catalog like v2 commands.
And also refine the code of AlterNamespaceSetProperties, AlterNamespaceSetPropertiesExec, DescribeNamespace, DescribeNamespaceExec to use SupportsNamespaces instead of CatalogPlugin for catalog parameter.
Why are the changes needed?
It's important to make all the commands have the same catalog/namespace resolution behavior, to avoid confusing end-users.
Does this PR introduce any user-facing change?
Yes, add "ALTER NAMESPACE ... SET LOCATION" whose function is same as "ALTER DATABASE ... SET LOCATION" and "ALTER SCHEMA ... SET LOCATION".
How was this patch tested?
New unit tests