-
Notifications
You must be signed in to change notification settings - Fork 29k
[SQL] Add type checking debugging functions #2657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
…fix to denote invalid or unresolved nodes.
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
| def apply(baseSet: Seq[Expression]) = | ||
| new AttributeSet( | ||
| baseSet | ||
| .flatMap(_.references) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should use toAttribute instead of references for NamedExpression? Otherwise the AttributeSet.contains method may return false result. IMO we should seprate the purpose of cacheing expressions as attributes from cacheing expression.refercences.
Adds some functions that were very useful when trying to track down the bug from #2656. This change also changes the tree output for query plans to include the
'prefix to unresolved nodes and!prefix to nodes that refer to non-existent attributes.