Skip to content

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Oct 4, 2014

Adds some functions that were very useful when trying to track down the bug from #2656. This change also changes the tree output for query plans to include the ' prefix to unresolved nodes and ! prefix to nodes that refer to non-existent attributes.

@SparkQA
Copy link

SparkQA commented Oct 4, 2014

QA tests have started for PR 2657 at commit 1d0c2da.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 4, 2014

QA tests have finished for PR 2657 at commit 1d0c2da.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class TypeCheck(child: SparkPlan) extends SparkPlan

@SparkQA
Copy link

SparkQA commented Oct 5, 2014

QA tests have started for PR 2657 at commit 763af15.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 5, 2014

QA tests have finished for PR 2657 at commit 763af15.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class TypeCheck(child: SparkPlan) extends SparkPlan

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2657 at commit 654b926.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2657 at commit 654b926.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have started for PR 2657 at commit 654b926.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have finished for PR 2657 at commit 654b926.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 371321c Oct 13, 2014
@marmbrus marmbrus deleted the debugging branch November 19, 2014 02:45
def apply(baseSet: Seq[Expression]) =
new AttributeSet(
baseSet
.flatMap(_.references)
Copy link
Contributor

@jiangxb1987 jiangxb1987 Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use toAttribute instead of references for NamedExpression? Otherwise the AttributeSet.contains method may return false result. IMO we should seprate the purpose of cacheing expressions as attributes from cacheing expression.refercences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants