Skip to content

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Nov 18, 2019

What changes were proposed in this pull request?

Checked with SQL Standard and PostgreSQL

CHAR is equivalent to CHARACTER. DEC is equivalent to DECIMAL. INT is equivalent to INTEGER. VARCHAR is equivalent to CHARACTER VARYING. ...

postgres=# select dec '1.0';
numeric
---------
1.0
(1 row)

postgres=# select CHARACTER '. second';
  bpchar
----------
 . second
(1 row)

postgres=# select CHAR '. second';
  bpchar
----------
 . second
(1 row)

Why are the changes needed?

For better ansi support

Does this PR introduce any user-facing change?

yes, we add character as char and dec as decimal

How was this patch tested?

add ut

@yaooqinn
Copy link
Member Author

cc @cloud-fan @maropu, pre-discussion @ #26537 (comment), thanks.

@SparkQA
Copy link

SparkQA commented Nov 18, 2019

Test build #114012 has finished for PR 26574 at commit ea5b5a4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants