[SPARK-30003][SQL] Do not throw stack overflow exception in non-root unknown hint resolution #26642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan |
HyukjinKwon
force-pushed
the
SPARK-30003
branch
from
7bae25b to
b7bf47a
Compare
HyukjinKwon
changed the title
|
Test build #114307 has finished for PR 26642 at commit
|
|
Test build #114308 has finished for PR 26642 at commit
|
maropu
approved these changes
Nov 23, 2019
Member
|
Nice catch! (btw, oh,... the jira number went over 30k...) |
Member
Author
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is rather a followup of #25464 (see https://github.com/apache/spark/pull/25464/files#r349543286)
It will cause an infinite recursion via mapping children - we should return the hint rather than its parent plan in unknown hint resolution.
Why are the changes needed?
Prevent Stack over flow during hint resolution.
Does this PR introduce any user-facing change?
Yes, it avoids stack overflow exception It was caused by #25464 and this is only in the master.
No behaviour changes to end users as it happened only in the master.
How was this patch tested?
Unittest was added.