Skip to content

[SPARK-29981][SQL][FOLLOWUP] Fix failing to run SQLQueryTestSuite #26657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 1 commit into from
Closed

[SPARK-29981][SQL][FOLLOWUP] Fix failing to run SQLQueryTestSuite #26657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,24 +43,30 @@ import org.apache.spark.tags.ExtendedSQLTest
*
* To run the entire test suite:
* {{{
* build/sbt "sql/test-only *SQLQueryTestSuite"
* build/sbt -Phive-1.2 "sql/test-only *SQLQueryTestSuite"
Copy link
Member

@dongjoon-hyun dongjoon-hyun Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, we had better use -Phive-2.3.
Second, please wait for a while. This PR will become obsolete soon.
As you see, it's still under slow changing to avoid any breakage.
Yesterday, we added hive-1.2/2.3. Today, we regenerates the manifest via test-dependencies.sh.
And, I'm working on the dependency changes. The following is the history of the migration.

a1706e2 [SPARK-30005][INFRA] Update test-dependencies.sh to check hive-1.2/2.3 profile
a60da23 [SPARK-30007][INFRA] Publish snapshot/release artifacts with -Phive-2.3 only
13338ea [SPARK-29554][SQL][FOLLOWUP] Rename Version to SparkVersion
6625b69 [SPARK-29981][BUILD][FOLLOWUP] Change hive.version.short
c98e5eb [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

Copy link
Member Author

@yaooqinn yaooqinn Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the instructions

Copy link
Member

@dongjoon-hyun dongjoon-hyun Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for understanding and sorry for the inconvenience. It's difficult to change the tires of the running cars.

Copy link
Member Author

@yaooqinn yaooqinn Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I will leave this pull request open for a while in case someone encounters the same issue until it is completely fixed.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm still working on, I create a WIP PR to share with you.

* }}}
*
* To run a single test file upon change:
* {{{
* build/sbt "~sql/test-only *SQLQueryTestSuite -- -z inline-table.sql"
* build/sbt -Phive-1.2 "~sql/test-only *SQLQueryTestSuite -- -z inline-table.sql"
* }}}
*
* To re-generate golden files for entire suite, run:
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite"
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt -Phive-1.2 "sql/test-only *SQLQueryTestSuite"
* }}}
*
* To re-generate golden file for a single test, run:
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite -- -z describe.sql"
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt -Phive-1.2 "sql/test-only *SQLQueryTestSuite --
* -z describe.sql"
* }}}
*
* Change profiles:
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus about the default profile (and it will become obsolete), such documentation should better go to somewhere related to Spark build or testing.

* We use `hadoop-2.7` as default now, so the above scripts is equivalent to
* `-Phadoop-2.7 -Phive-1.2`. You can change profiles to `-Phadoop-3.2 -Phive-2.3` to verify higher
* hadoop and hive versions.
*
* The format for input files is simple:
* 1. A list of SQL queries separated by semicolon.
* 2. Lines starting with -- are treated as comments and ignored.
Expand Down
8 changes: 7 additions & 1 deletion ...er/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,19 @@ import org.apache.spark.sql.types._
* To run the entire test suite:
* {{{
* build/sbt "hive-thriftserver/test-only *ThriftServerQueryTestSuite" -Phive-thriftserver
* -Phive-1.2
* }}}
*
* This test suite won't generate golden files. To re-generate golden files for entire suite, run:
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite"
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt -Phive-1.2 "sql/test-only *SQLQueryTestSuite"
* }}}
*
* Change profiles:
* We use `hadoop-2.7` as default now, so the above scripts is equivalent to
* `-Phadoop-2.7 -Phive-1.2`. You can change profiles to `-Phadoop-3.2 -Phive-2.3` to verify higher
* hadoop and hive versions.
*
* TODO:
* 1. Support UDF testing.
* 2. Support DESC command.
Expand Down