Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

add setWeightCol and setMinWeightFractionPerNode in Python side of GBTClassifier and GBTRegressor

Why are the changes needed?

#25926 added setWeightCol and setMinWeightFractionPerNode in GBTs on scala side. This PR will add setWeightCol and setMinWeightFractionPerNode in GBTs on python side

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

doc test

@SparkQA
Copy link

SparkQA commented Dec 6, 2019

Test build #114929 has finished for PR 26774 at commit 12dd439.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 6, 2019

Test build #114952 has finished for PR 26774 at commit 9a83f92.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just exposes a recently added feature in Python? LGTM pending tests. @zhengruifeng

@huaxingao
Copy link
Contributor Author

@srowen Yes, it just exposes the recently added feature in Python.

@zhengruifeng
Copy link
Contributor

Thanks for pinging me.
LGTM

@srowen srowen closed this in 8a9cccf Dec 9, 2019
@srowen
Copy link
Member

srowen commented Dec 9, 2019

Merged to master

@huaxingao
Copy link
Contributor Author

Thanks! @srowen @zhengruifeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants