Skip to content

[MINOR][SQL][SS] Remove TODO comments as var in case class is discouraged but worth breaking it #26992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HeartSaVioR wants to merge 1 commit into from
Closed

[MINOR][SQL][SS] Remove TODO comments as var in case class is discouraged but worth breaking it #26992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ private[kafka010] class InternalKafkaConsumer(
}
}

// TODO: consider changing this to normal class, as having mutable variables in
// case class sounds weird.
/**
* The internal object to store the fetched data from Kafka consumer and the next offset to poll.
*
Expand Down Expand Up @@ -192,8 +190,6 @@ private[kafka010] case class FetchedData(
def offsetAfterPoll: Long = _offsetAfterPoll
}

// TODO: consider changing this to normal class, as having mutable variables in
// case class sounds weird.
/**
* The internal object returned by the `fetchRecord` method. If `record` is empty, it means it is
* invisible (either a transaction message, or an aborted message when the consumer's
Expand Down