Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

add weight support in BisectingKMeans

Why are the changes needed?

BisectingKMeans should support instance weighting

Does this PR introduce any user-facing change?

Yes. BisectingKMeans.setWeight

How was this patch tested?

Unit test

@SparkQA
Copy link

SparkQA commented Dec 29, 2019

Test build #115895 has finished for PR 27035 at commit 5e7ccdb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 29, 2019

Test build #115898 has finished for PR 27035 at commit e8bd33f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

@zhengruifeng @srowen

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, remove space before first i

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just keep existing line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean val d = input.map(_._1.size).first()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that var dataVectorWithNorm is only used to get norms, so what about removing it and make val norms = input.map(d => Vectors.norm(d._1, 2.0))...

@huaxingao
Copy link
Contributor Author

huaxingao commented Dec 30, 2019

I saw the conflict file. I will fix this after #27052 is merged, so I don't have to rebase twice.

@SparkQA
Copy link

SparkQA commented Dec 30, 2019

Test build #115962 has finished for PR 27035 at commit 987ba2e.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Contributor

ping @huaxingao #27052 is merged

@SparkQA
Copy link

SparkQA commented Jan 6, 2020

Test build #116128 has finished for PR 27035 at commit ae7948b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 7, 2020

Test build #116255 has finished for PR 27035 at commit 6ca078e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 13, 2020

Merged to master

@srowen srowen closed this in f77dcfc Jan 13, 2020
@huaxingao
Copy link
Contributor Author

Thanks! @srowen @zhengruifeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants