[SPARK-30420][SQL] V2 commands resolves namespaces with new resolution framework #27095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
commented
Jan 4, 2020
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Show resolved
Hide resolved
|
Test build #116109 has finished for PR 27095 at commit
|
cloud-fan
reviewed
Jan 6, 2020
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 7, 2020
| case s @ ShowTablesStatement(UnresolvedNamespace(Seq()), _) => | ||
| s.copy(namespace = | ||
| ResolvedNamespace(currentCatalog.asNamespaceCatalog, catalogManager.currentNamespace)) | ||
| case UnresolvedNamespace(Seq()) => |
Contributor
There was a problem hiding this comment.
We can move this logic to CatalogAndNamespace, but I'm fine with what it is now.
cloud-fan
reviewed
Jan 7, 2020
| */ | ||
| case class CreateNamespaceStatement( | ||
| namespace: Seq[String], | ||
| namespace: LogicalPlan, |
Contributor
There was a problem hiding this comment.
I'm not very sure about this. For CREATE commands, they only need to know the catalog, but no need to lookup table or namespace. I think we can keep using Seq[String], still handle the commands in ResolveCatalogs/ResolveSessionCatalogs and resolve the Seq[String] directly.
Contributor
Author
There was a problem hiding this comment.
yea you are right, and in this case, it will be consistent for tables as well.
Contributor
|
LGTM except one comment |
cloud-fan
approved these changes
Jan 7, 2020
|
Test build #116206 has finished for PR 27095 at commit
|
|
Test build #116218 has finished for PR 27095 at commit
|
Contributor
Author
|
Retest this please |
|
Test build #116233 has finished for PR 27095 at commit
|
Contributor
|
thanks, merging to master! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 8, 2020
…pace commands ### What changes were proposed in this pull request? This is a follow-up to address the following comment: #27095 (comment) Currently, a SQL command string is parsed to a "statement" logical plan, converted to a logical plan with catalog/namespace, then finally converted to a physical plan. With the new resolution framework, there is no need to create a "statement" logical plan; a logical plan can contain `UnresolvedNamespace` which will be resolved to a `ResolvedNamespace`. This should simply the code base and make it a bit easier to add a new command. ### Why are the changes needed? Clean up codebase. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests should cover the changes. Closes #27125 from imback82/SPARK-30214-followup. Authored-by: Terry Kim <yuminkim@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
imback82
changed the title
rdblue
pushed a commit
to Netflix/spark
that referenced
this pull request
Jan 21, 2020
…pace commands This is a follow-up to address the following comment: apache/spark#27095 (comment) Currently, a SQL command string is parsed to a "statement" logical plan, converted to a logical plan with catalog/namespace, then finally converted to a physical plan. With the new resolution framework, there is no need to create a "statement" logical plan; a logical plan can contain `UnresolvedNamespace` which will be resolved to a `ResolvedNamespace`. This should simply the code base and make it a bit easier to add a new command. Clean up codebase. No Existing tests should cover the changes. Closes #27125 from imback82/SPARK-30214-followup. Authored-by: Terry Kim <yuminkim@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#26847 introduced new framework for resolving catalog/namespaces. This PR proposes to integrate commands that need to resolve namespaces into the new framework.
Why are the changes needed?
This is one of the work items for moving into the new resolution framework. Resolving v1/v2 tables with the new framework will be followed up in different PRs.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests should cover the changes.