Skip to content

[SPARK-30335][SQL][DOCS] Add a note first, last, collect_list and collect_set can be non-deterministic in SQL function docs as well #27099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HyukjinKwon wants to merge 3 commits into from
Closed

[SPARK-30335][SQL][DOCS] Add a note first, last, collect_list and collect_set can be non-deterministic in SQL function docs as well #27099

HyukjinKwon wants to merge 3 commits into from

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 6, 2020

What changes were proposed in this pull request?

This PR adds a note first and last can be non-deterministic in SQL function docs as well.
This is already documented in functions.scala.

Why are the changes needed?

Some people look reading SQL docs only.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Jenkins will test.

@HyukjinKwon HyukjinKwon changed the title [SPARK-30335][SQL][DOCS] Note first and last can be non-deterministic in SQL function docs as well [SPARK-30335][SQL][DOCS] add a note first and last can be non-deterministic in SQL function docs as well Jan 6, 2020
@HyukjinKwon HyukjinKwon changed the title [SPARK-30335][SQL][DOCS] add a note first and last can be non-deterministic in SQL function docs as well [SPARK-30335][SQL][DOCS] Add a note first and last can be non-deterministic in SQL function docs as well Jan 6, 2020
@SparkQA
Copy link

SparkQA commented Jan 6, 2020

Test build #116133 has finished for PR 27099 at commit e4d206d.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 6, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Jan 6, 2020

Test build #116146 has finished for PR 27099 at commit e4d206d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Jan 6, 2020
View reviewed changes
@SparkQA
Copy link

SparkQA commented Jan 6, 2020

Test build #116173 has finished for PR 27099 at commit 85da39c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon changed the title [SPARK-30335][SQL][DOCS] Add a note first and last can be non-deterministic in SQL function docs as well [SPARK-30335][SQL][DOCS] Add a note first, last, collect_list and collect_set can be non-deterministic in SQL function docs as well Jan 7, 2020
@SparkQA
Copy link

SparkQA commented Jan 7, 2020

Test build #116195 has finished for PR 27099 at commit 7de8de8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 7, 2020

Thanks @dongjoon-hyun, @yaooqinn, @srowen.

Merged to master.

@HyukjinKwon HyukjinKwon deleted the SPARK-30335 branch March 3, 2020 01:16
@JoshRosen JoshRosen mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen left review comments

@yaooqinn yaooqinn yaooqinn left review comments

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HyukjinKwon @SparkQA @srowen @yaooqinn @dongjoon-hyun