-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30431][SQL] Update SqlBase.g4 to create commentSpec pattern like locationSpec #27102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… same as locationSpec
|
Test build #116147 has finished for PR 27102 at commit
|
|
Test build #116151 has finished for PR 27102 at commit
|
|
Test build #116156 has finished for PR 27102 at commit
|
|
Cc @cloud-fan thanks |
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
Outdated
Show resolved
Hide resolved
|
Test build #116202 has finished for PR 27102 at commit
|
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
|
Test build #116204 has finished for PR 27102 at commit
|
|
Test build #116210 has finished for PR 27102 at commit
|
|
Test build #116212 has finished for PR 27102 at commit
|
|
retest this please |
|
Test build #116229 has finished for PR 27102 at commit
|
|
thanks, merging to master! |
What changes were proposed in this pull request?
In
SqlBase.g4, thecommentclause is used asCOMMENT comment=STRINGandCOMMENT STRINGin many places.While the
locationclause often appears along with thecommentclause with a pattern defined aslocationSpec : LOCATION STRING ;Then, we have to visit
locationSpecas aListbut comment as a single token.We defined
commentSpecfor the comment clause to simplify and unify the grammar and the invocations.Why are the changes needed?
To simplify the grammar.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests