[SPARK-30472][SQL] ANSI SQL: Throw exception on format invalid and overflow when casting String to IntegerType. #27152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalid and overflow.
turboFei
changed the title
|
Can one of the admins verify this patch? |
turboFei
changed the title
turboFei
changed the title
Member
Author
Contributor
|
I guess this problem is solved in this -> #26933 |
Member
Author
|
thanks. closed @iRakson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR, when spark.sql.ansi.enabled is true.
When casting stringType to Int.
If the string format is invalid or its value overflow the range of Int, we would throw exception to keep consistent with ANSI.
Why are the changes needed?
To keep consistent with ANSI, when spark.sql.ansi.enable is true.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added Unit Test.