[SPARK-30535][SQL][FOLLOWUP] Update error message for ALTER TABLE when table is resolved to temp view #27315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #117205 has finished for PR 27315 at commit
|
| -- !query 20 output | ||
| org.apache.spark.sql.AnalysisException | ||
| temp_view is a temp view not a table.; line 1 pos 0 | ||
| Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead; line 1 pos 0 |
Member
There was a problem hiding this comment.
Hi, @cloud-fan and @imback82
Cannot alter a view with ALTER TABLE. looks okay, but Please use ALTER VIEW instead looks like we mislead the users to try ALTER VIEW temp_view CHANGE a TYPE INT COMMENT 'this is column a'.
Member
There was a problem hiding this comment.
The other changes in this PR are the same. The directional message parts look misleading.
Contributor
There was a problem hiding this comment.
This is a good point. How about just Cannot alter a temp view with ALTER TABLE. as the error message?
Contributor
|
cc @imback82 @cloud-fan I'm planning to revert #27243 because of reasons described in #27243 (comment), therefore please hold off on merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR address: #27243 (comment).
The error is now the same whether a table is resolved to a view or a temp view for ALTER TABLE commands.
Why are the changes needed?
To unify the error message regardless of whether a table is resolved to a view or a temp view for ALTER TABLE commands.
Does this PR introduce any user-facing change?
The previous error message:
New error message (same as view):
How was this patch tested?
Updated existing tests to reflect the new error message.