[SPARK-30630][ML][2.4] Deprecate numTrees in GBT in 2.4.5 #27352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| /** | ||
| * Number of trees in ensemble | ||
| * | ||
| * @deprecated Use [[getNumTrees]] instead. This method will be removed in 3.0.0 |
| /** | ||
| * Number of trees in ensemble | ||
| * | ||
| * @deprecated Use [[getNumTrees]] instead. This method will be removed in 3.0.0 |
dongjoon-hyun
changed the title
|
Test build #117339 has finished for PR 27352 at commit
|
|
Test build #117341 has finished for PR 27352 at commit
|
Contributor
Author
|
Retest this please. |
|
Test build #117347 has finished for PR 27352 at commit
|
dongjoon-hyun
approved these changes
Jan 24, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @huaxingao .
Merged to branch-2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 24, 2020
### What changes were proposed in this pull request?
Deprecate numTrees in GBT in 2.4.5 so it can be removed in 3.0.0
### Why are the changes needed?
Currently, GBT has
```
/**
* Number of trees in ensemble
*/
Since("2.0.0")
val getNumTrees: Int = trees.length
```
and
```
/** Number of trees in ensemble */
val numTrees: Int = trees.length
```
I think we should remove one of them. I will deprecate it in 2.4.5 and remove it in 3.0.0
### Does this PR introduce any user-facing change?
Deprecate numTrees in 2.4.5
### How was this patch tested?
Existing tests
Closes #27352 from huaxingao/spark-tree.
Authored-by: Huaxin Gao <huaxing@us.ibm.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Contributor
Author
|
Thank you very much!! @dongjoon-hyun |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 24, 2020
### What changes were proposed in this pull request?
Remove ```numTrees``` in GBT in 3.0.0.
### Why are the changes needed?
Currently, GBT has
```
/**
* Number of trees in ensemble
*/
Since("2.0.0")
val getNumTrees: Int = trees.length
```
and
```
/** Number of trees in ensemble */
val numTrees: Int = trees.length
```
I think we should remove one of them. We deprecated it in 2.4.5 via #27352.
### Does this PR introduce any user-facing change?
Yes, remove ```numTrees``` in GBT in 3.0.0
### How was this patch tested?
existing tests
Closes #27330 from huaxingao/spark-numTrees.
Authored-by: Huaxin Gao <huaxing@us.ibm.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Deprecate numTrees in GBT in 2.4.5 so it can be removed in 3.0.0
Why are the changes needed?
Currently, GBT has
and
I think we should remove one of them. I will deprecate it in 2.4.5 and remove it in 3.0.0
Does this PR introduce any user-facing change?
Deprecate numTrees in 2.4.5
How was this patch tested?
Existing tests