Skip to content

Conversation

@kiszk
Copy link
Member

@kiszk kiszk commented Jan 30, 2020

What changes were proposed in this pull request?

This PR is a follow-up of #25728. #25728 introduces additional arguments to determine sort order. Thus, this function does not sort only in ascending order. However, the description was not updated.
This PR updates the description to follow the latest feature.

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests since this PR just updates description text.

@kiszk
Copy link
Member Author

kiszk commented Jan 30, 2020

cc @ueshin @srowen

@kiszk kiszk changed the title [SPARK-29020][FOLLOWUP] Update description [SPARK-29020][FOLLOWUP][SQL] Update description of array_sort function Jan 30, 2020
@srowen
Copy link
Member

srowen commented Jan 30, 2020

Jenkins test this please

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117568 has finished for PR 27404 at commit 7c16827.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @kiszk , @srowen , @MaxGekk .
All tests passed already and the last commit is only touching two words.
Merged to master.

@SparkQA
Copy link

SparkQA commented Jan 30, 2020

Test build #117572 has finished for PR 27404 at commit 232d560.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants