[SPARK-29779][SPARK-30479][CORE][SQL][FOLLOWUP] Reflect review comments on post-hoc review #27414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review comments on post-hoc review
Contributor
Author
|
cc. @HyukjinKwon |
|
Test build #117639 has finished for PR 27414 at commit
|
srowen
approved these changes
Jan 31, 2020
dongjoon-hyun
approved these changes
Jan 31, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @HeartSaVioR and @srowen .
Merged to master.
Contributor
Author
|
Thanks all for reviewing and merging! FYI to @HyukjinKwon The PR only addressed part of your review comments, and I left my comment per comment to explain why I don't think it should be addressed. Please continue commenting on original comment if you don't agree with my comment. |
HeartSaVioR
deleted the
SPARK-28869-SPARK-29779-SPARK-30479-FOLLOWUP-posthoc-reviews
branch
HyukjinKwon
reviewed
Feb 1, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM. thanks for this followup @HeartSaVioR, and all for reviewing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reflects review comments on post-hoc review among PRs for SPARK-29779 (#27085), SPARK-30479 (#27164). The list of review comments this PR addresses are below:
I also applied review comments to the CORE module (BasicEventFilterBuilder.scala) as well, as the review comments for SQL/core module (SQLEventFilterBuilder.scala) can be applied there as well.
Why are the changes needed?
There're post-hoc reviews on PRs for such issues, like links in above section.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs.