-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30715][K8S] Bump fabric8 to 4.7.1 #27443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
|
Hi, @onursatici . Is this for improvement or for a bug fix? |
|
Test build #117779 has finished for PR 27443 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onursatici . Ur, could you run K8s integration test on this PR locally first?
[INFO] Compiling 19 Scala sources to /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/target/test-classes ...
[ERROR] [Error] /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala:58: ')' expected but string literal found.
[ERROR] [Error] /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala:59: ';' expected but ')' found.
|
Test build #117780 has finished for PR 27443 at commit
|
1deffe7 to
399408d
Compare
|
@onursatici . Since you are active contributor in K8s area, I want to recommend to keep all sections of the PR template. Especially,
In short, please recover the deleted two sections. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
It seems that there exist 3 failures. |
|
Test build #117781 has finished for PR 27443 at commit
|
|
Thanks for having a look @dongjoon-hyun, will fix the integrations tests and will let you know |
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Oh, it seems that two failures are gone. The remaining one is known to be a flaky test. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master.
I verified this locally. The flaky failure is irrelevant to this PR.
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python2 to test a pyfiles example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Run SparkR on simple dataframe.R example
Run completed in 13 minutes, 30 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
|
Thank you, @onursatici . |
|
I'll backport this to |
### What changes were proposed in this pull request? Bump fabric8 kubernetes-client to 4.7.1 ### Why are the changes needed? New fabric8 version brings support for Kubernetes 1.17 clusters. Full release notes: - https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.0 - https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.1 ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing unit and integration tests cover creation of K8S objects. Adjusted them to work with the new fabric8 version Closes #27443 from onursatici/os/bump-fabric8. Authored-by: Onur Satici <onursatici@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 86fdb81) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Bump fabric8 kubernetes-client to 4.7.1 New fabric8 version brings support for Kubernetes 1.17 clusters. Full release notes: - https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.0 - https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.1 No Existing unit and integration tests cover creation of K8S objects. Adjusted them to work with the new fabric8 version Closes apache#27443 from onursatici/os/bump-fabric8. Authored-by: Onur Satici <onursatici@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
Bump fabric8 kubernetes-client to 4.7.1
Why are the changes needed?
New fabric8 version brings support for Kubernetes 1.17 clusters.
Full release notes:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit and integration tests cover creation of K8S objects. Adjusted them to work with the new fabric8 version