Skip to content

Conversation

@onursatici
Copy link
Contributor

@onursatici onursatici commented Feb 3, 2020

What changes were proposed in this pull request?

Bump fabric8 kubernetes-client to 4.7.1

Why are the changes needed?

New fabric8 version brings support for Kubernetes 1.17 clusters.
Full release notes:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing unit and integration tests cover creation of K8S objects. Adjusted them to work with the new fabric8 version

@dongjoon-hyun
Copy link
Member

ok to test

@dongjoon-hyun
Copy link
Member

Hi, @onursatici . Is this for improvement or for a bug fix?

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Test build #117779 has finished for PR 27443 at commit 9b305b7.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22541/

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22541/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onursatici . Ur, could you run K8s integration test on this PR locally first?

[INFO] Compiling 19 Scala sources to /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/target/test-classes ...
[ERROR] [Error] /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala:58: ')' expected but string literal found.
[ERROR] [Error] /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala:59: ';' expected but ')' found.

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Test build #117780 has finished for PR 27443 at commit 9f6fc54.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30715][K8S] bump fabric8 to 4.7.1 [SPARK-30715][K8S] Bump fabric8 to 4.7.1 Feb 3, 2020
@dongjoon-hyun
Copy link
Member

@onursatici . Since you are active contributor in K8s area, I want to recommend to keep all sections of the PR template. Especially, ### Why are the changes needed? section. You can add the following release note at that section simply.

In short, please recover the deleted two sections.

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22542/

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22542/

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22543/

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22543/

@dongjoon-hyun
Copy link
Member

It seems that there exist 3 failures.

KubernetesSuite:
- Run SparkPi with no resources *** FAILED ***
  The code passed to eventually never returned normally. Attempted 70 times over 2.0014648788833336 minutes. Last failure message: false was not true. (KubernetesSuite.scala:315)
- Run SparkPi with a very long application name. *** FAILED ***
  The code passed to eventually never returned normally. Attempted 70 times over 2.0008292973333335 minutes. Last failure message: false was not true. (KubernetesSuite.scala:315)
...
- Launcher client dependencies *** FAILED ***
  The code passed to eventually never returned normally. Attempted 130 times over 4.00124932035 minutes. Last failure message: false was not true. (KubernetesSuite.scala:315)

@SparkQA
Copy link

SparkQA commented Feb 3, 2020

Test build #117781 has finished for PR 27443 at commit 2a3a946.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@onursatici
Copy link
Contributor Author

Thanks for having a look @dongjoon-hyun, will fix the integrations tests and will let you know

@onursatici
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Feb 4, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22612/

@SparkQA
Copy link

SparkQA commented Feb 4, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22612/

@dongjoon-hyun
Copy link
Member

Oh, it seems that two failures are gone. The remaining one is known to be a flaky test.

- Launcher client dependencies *** FAILED ***
  The code passed to eventually never returned normally. Attempted 130 times over 4.0007343233 minutes. Last failure message: false was not true. (KubernetesSuite.scala:315)

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

I verified this locally. The flaky failure is irrelevant to this PR.

KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark with Python2 to test a pyfiles example
- Run PySpark with Python3 to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- Run SparkR on simple dataframe.R example
Run completed in 13 minutes, 30 seconds.
Total number of tests run: 19
Suites: completed 2, aborted 0
Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
All tests passed.

@dongjoon-hyun
Copy link
Member

Thank you, @onursatici .

@dongjoon-hyun
Copy link
Member

I'll backport this to branch-3.0 to address the recent JDK8 issue on K8s 1.17.x.

dongjoon-hyun pushed a commit that referenced this pull request May 24, 2020
### What changes were proposed in this pull request?
Bump fabric8 kubernetes-client to 4.7.1

### Why are the changes needed?
New fabric8 version brings support for Kubernetes 1.17 clusters.
Full release notes:
- https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.0
- https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.1

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
Existing unit and integration tests cover creation of K8S objects. Adjusted them to work with the new fabric8 version

Closes #27443 from onursatici/os/bump-fabric8.

Authored-by: Onur Satici <onursatici@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 86fdb81)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
akirillov pushed a commit to d2iq-archive/spark that referenced this pull request Aug 19, 2020
Bump fabric8 kubernetes-client to 4.7.1

New fabric8 version brings support for Kubernetes 1.17 clusters.
Full release notes:
- https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.0
- https://github.com/fabric8io/kubernetes-client/releases/tag/v4.7.1

No

Existing unit and integration tests cover creation of K8S objects. Adjusted them to work with the new fabric8 version

Closes apache#27443 from onursatici/os/bump-fabric8.

Authored-by: Onur Satici <onursatici@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants