-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3890][Docs]remove redundant spark.executor.memory in doc #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
QA tests have started for PR 2745 at commit
|
|
QA tests have finished for PR 2745 at commit
|
|
Test PASSed. |
|
It could be because it belongs to both categories (run time environment and application behavior), but yes I think we should remove one. |
|
Actually I don't understant what |
|
QA tests have started for PR 2745 at commit
|
|
QA tests have finished for PR 2745 at commit
|
|
Test PASSed. |
docs/configuration.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add periods in these two places since it makes it look like part of the code.
|
@srowen I checked and found the line contains more than 100 charactors already, so keep the wrapping. The period is also deleted. |
|
Ok, I'll merge this into master and 1.1. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be a period here, but I'll fix this when I merge it.
Introduced in pwendell@f7e79bc, I'm not sure why we need two spark.executor.memory here. Author: WangTaoTheTonic <barneystinson@aliyun.com> Author: WangTao <barneystinson@aliyun.com> Closes #2745 from WangTaoTheTonic/redundantconfig and squashes the following commits: e7564dc [WangTao] too long line fdbdb1f [WangTaoTheTonic] trivial workaround d06b6e5 [WangTaoTheTonic] remove redundant spark.executor.memory in doc (cherry picked from commit e7f4ea8) Signed-off-by: Andrew Or <andrewor14@gmail.com>
Introduced in pwendell@f7e79bc, I'm not sure why we need two spark.executor.memory here.