Skip to content

Conversation

@WangTaoTheTonic
Copy link
Contributor

Introduced in pwendell@f7e79bc, I'm not sure why we need two spark.executor.memory here.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have started for PR 2745 at commit d06b6e5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have finished for PR 2745 at commit d06b6e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • protected case class Keyword(str: String)
    • class SqlLexical(val keywords: Seq[String]) extends StdLexical
    • case class FloatLit(chars: String) extends Token
    • class SqlParser extends AbstractSparkSQLParser
    • case class SetCommand(kv: Option[(String, Option[String])]) extends Command
    • case class ShellCommand(cmd: String) extends Command
    • case class SourceCommand(filePath: String) extends Command
    • case class SetCommand(kv: Option[(String, Option[String])], output: Seq[Attribute])(

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21567/Test PASSed.

@andrewor14
Copy link
Contributor

It could be because it belongs to both categories (run time environment and application behavior), but yes I think we should remove one.

@WangTaoTheTonic
Copy link
Contributor Author

Actually I don't understant what Runtime Environment category means.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have started for PR 2745 at commit fdbdb1f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 12, 2014

QA tests have finished for PR 2745 at commit fdbdb1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21652/
Test PASSed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add periods in these two places since it makes it look like part of the code.

@WangTaoTheTonic
Copy link
Contributor Author

@srowen I checked and found the line contains more than 100 charactors already, so keep the wrapping. The period is also deleted.

@andrewor14
Copy link
Contributor

Ok, I'll merge this into master and 1.1. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be a period here, but I'll fix this when I merge it.

@asfgit asfgit closed this in e7f4ea8 Oct 17, 2014
asfgit pushed a commit that referenced this pull request Oct 17, 2014
Introduced in pwendell@f7e79bc, I'm not sure why we need two spark.executor.memory here.

Author: WangTaoTheTonic <barneystinson@aliyun.com>
Author: WangTao <barneystinson@aliyun.com>

Closes #2745 from WangTaoTheTonic/redundantconfig and squashes the following commits:

e7564dc [WangTao] too long line
fdbdb1f [WangTaoTheTonic] trivial workaround
d06b6e5 [WangTaoTheTonic] remove redundant spark.executor.memory in doc

(cherry picked from commit e7f4ea8)
Signed-off-by: Andrew Or <andrewor14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants