[SPARK-27986][SQL][followup] window aggregate function with filter predicate is not supported #27476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Thank you. LGTM. |
beliefer
reviewed
Feb 6, 2020
| e.failAnalysis( | ||
| "distinct aggregates are not allowed in observed metrics, but found: " + s.sql) | ||
| case a: AggregateExpression if a.filter.isDefined => | ||
| e.failAnalysis("aggregates with filter predicate are not allowed in " + |
Contributor
There was a problem hiding this comment.
I lost the information. Thank you.
|
Test build #117990 has finished for PR 27476 at commit
|
|
Test build #117991 has finished for PR 27476 at commit
|
dongjoon-hyun
approved these changes
Feb 6, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you all.
Merged to master/3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 6, 2020
…edicate is not supported ### What changes were proposed in this pull request? This is a followup of #26656. We don't support window aggregate function with filter predicate yet and we should fail explicitly. Observable metrics has the same issue. This PR fixes it as well. ### Why are the changes needed? If we simply ignore filter predicate when we don't support it, the result is wrong. ### Does this PR introduce any user-facing change? yea, fix the query result. ### How was this patch tested? new tests Closes #27476 from cloud-fan/filter. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 5a4c70b) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…edicate is not supported ### What changes were proposed in this pull request? This is a followup of apache#26656. We don't support window aggregate function with filter predicate yet and we should fail explicitly. Observable metrics has the same issue. This PR fixes it as well. ### Why are the changes needed? If we simply ignore filter predicate when we don't support it, the result is wrong. ### Does this PR introduce any user-facing change? yea, fix the query result. ### How was this patch tested? new tests Closes apache#27476 from cloud-fan/filter. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #26656.
We don't support window aggregate function with filter predicate yet and we should fail explicitly.
Observable metrics has the same issue. This PR fixes it as well.
Why are the changes needed?
If we simply ignore filter predicate when we don't support it, the result is wrong.
Does this PR introduce any user-facing change?
yea, fix the query result.
How was this patch tested?
new tests