[SPARK-31058] [SQL] [test-hive1.2] Consolidate the implementation of quoteIfNeeded
#27814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbtsai
requested review from
cloud-fan,
dongjoon-hyun,
gengliangwang and
wangyum
dbtsai
changed the title
quoteIfNeededquoteIfNeeded
Member
Author
|
jenkins retest this please |
|
Test build #119414 has finished for PR 27814 at commit
|
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Implicits.scala
Outdated
Show resolved
Hide resolved
dbtsai
added a commit
that referenced
this pull request
Mar 6, 2020
…uoteIfNeeded` ### What changes were proposed in this pull request? There are two implementation of quoteIfNeeded. One is in `org.apache.spark.sql.connector.catalog.CatalogV2Implicits.quote` and the other is in `OrcFiltersBase.quoteAttributeNameIfNeeded`. This PR will consolidate them into one. ### Why are the changes needed? Simplify the codebase. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UTs. Closes #27814 from dbtsai/SPARK-31058. Authored-by: DB Tsai <d_tsai@apple.com> Signed-off-by: DB Tsai <d_tsai@apple.com> (cherry picked from commit fe126a6) Signed-off-by: DB Tsai <d_tsai@apple.com>
Member
Author
|
Merged in master/3.0. Thanks. |
|
Test build #119422 has finished for PR 27814 at commit
|
Member
Author
|
Note that, the test was failing on non related kafka test due to timeout. |
|
Test build #119412 has finished for PR 27814 at commit
|
|
Test build #119417 has finished for PR 27814 at commit
|
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…uoteIfNeeded` ### What changes were proposed in this pull request? There are two implementation of quoteIfNeeded. One is in `org.apache.spark.sql.connector.catalog.CatalogV2Implicits.quote` and the other is in `OrcFiltersBase.quoteAttributeNameIfNeeded`. This PR will consolidate them into one. ### Why are the changes needed? Simplify the codebase. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UTs. Closes apache#27814 from dbtsai/SPARK-31058. Authored-by: DB Tsai <d_tsai@apple.com> Signed-off-by: DB Tsai <d_tsai@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two implementation of quoteIfNeeded. One is in
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.quoteand the other is inOrcFiltersBase.quoteAttributeNameIfNeeded. This PR will consolidate them into one.Why are the changes needed?
Simplify the codebase.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs.