-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3935][Core] log the number of records that has been written #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
ok to test. Hey @jackylk could you be a little more specific in your log message? (What records, logged to where?) |
|
QA tests have started for PR 2791 at commit
|
|
QA tests have finished for PR 2791 at commit
|
|
Test PASSed. |
|
how about this? |
|
What about just removing this instead of logging it? If it's un-used, we can just remove it. |
|
ok |
|
QA tests have started for PR 2791 at commit
|
|
QA tests have finished for PR 2791 at commit
|
|
Test PASSed. |
|
Ok thanks I merge |
|
Hey @jackylk do you have a JIRA account? |
|
For this PR, I used wangfei's account in JIRA. I will create my account next time. |
|
Ok, I'll put you under wangfei |
There is a unused variable(count) in saveAsHadoopDataset in PairRDDFunctions.scala. The initial idea of this variable seems to count the number of records, so I am adding a log statement to log the number of records that has been written to the writer.