Skip to content

Conversation

@jackylk
Copy link
Contributor

@jackylk jackylk commented Oct 14, 2014

There is a unused variable(count) in saveAsHadoopDataset in PairRDDFunctions.scala. The initial idea of this variable seems to count the number of records, so I am adding a log statement to log the number of records that has been written to the writer.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

ok to test. Hey @jackylk could you be a little more specific in your log message? (What records, logged to where?)

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have started for PR 2791 at commit 3bf43c7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have finished for PR 2791 at commit 3bf43c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21833/
Test PASSed.

@jackylk
Copy link
Contributor Author

jackylk commented Oct 17, 2014

how about this?

        logInfo(s"$count records of RDD_${self.id} are written to ${hadoopConf.get("mapred.output.dir")}")

@pwendell
Copy link
Contributor

What about just removing this instead of logging it? If it's un-used, we can just remove it.

@jackylk
Copy link
Contributor Author

jackylk commented Oct 17, 2014

ok

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have started for PR 2791 at commit a874047.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have finished for PR 2791 at commit a874047.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21853/
Test PASSed.

@andrewor14
Copy link
Contributor

Ok thanks I merge

@andrewor14
Copy link
Contributor

Hey @jackylk do you have a JIRA account?

@asfgit asfgit closed this in c351862 Oct 17, 2014
@jackylk
Copy link
Contributor Author

jackylk commented Oct 18, 2014

For this PR, I used wangfei's account in JIRA. I will create my account next time.

@andrewor14
Copy link
Contributor

Ok, I'll put you under wangfei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants