[SPARK-31231][BUILD][FOLLOW-UP] Set the upper bound (before 46.1.0) for setuptools in pip package test #28005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I will port this through master, branch-3.0 and branch-2.4 to reduce the diff between branches. |
Member
Author
|
I will use #28006 to check branch-2.4 for sure. |
|
Test build #120291 has finished for PR 28005 at commit
|
|
Test build #120300 has finished for PR 28005 at commit
|
|
Test build #120302 has finished for PR 28005 at commit
|
Member
Author
|
retest this please |
|
Test build #120308 has finished for PR 28005 at commit
|
Member
|
Retest this please. |
|
Test build #120321 has finished for PR 28005 at commit
|
Member
Author
|
retest this please |
|
Test build #120337 has finished for PR 28005 at commit
|
Member
Author
|
retest this please |
Member
Author
|
There are a bunch of flaky tests here ... JIRA: SPARK-31248 Strack traceJIRA: SPARK-31249 Strack traceJIRA: SPARK-31250 Strack traceJIRA: SPARK-31251 Strack tracecc @jiangxb1987, @Ngone51, @gaborgsomogyi, @HeartSaVioR, @tgravescs, @zsxwing FYI |
gaborgsomogyi
approved these changes
Mar 25, 2020
Contributor
gaborgsomogyi
left a comment
gaborgsomogyi
left a comment
There was a problem hiding this comment.
LGTM (pending tests).
|
Test build #120358 has finished for PR 28005 at commit
|
dongjoon-hyun
approved these changes
Mar 25, 2020
Member
|
cc @srowen |
Member
Author
|
Thanks guys. pypa/setuptools#2046 this issue seems fixed quickly, and seems they released new maintenance versions. Let me try to revert the previous fix, and see if build passes in this PR. |
…in pip package test" This reverts commit c181c45.
HyukjinKwon
force-pushed
the
investigate-pip-packaging-followup
branch
from
6999fa7 to
d07a80b
Compare
HyukjinKwon
changed the title
|
Test build #120383 has finished for PR 28005 at commit
|
Member
Author
|
Okay, appearntly it's not fixed yet. I am going back to the original fix and merge it. |
… 46.0.0 in pip package test"" This reverts commit d07a80b.
HyukjinKwon
changed the title
Member
Author
|
Same changes were already tested and passed. Merged to master, branch-3.0, and branch-2.4. |
HyukjinKwon
added a commit
that referenced
this pull request
Mar 26, 2020
…or setuptools in pip package test ## What changes were proposed in this pull request? This PR is a followup of #27995. Rather then pining setuptools version, it sets upper bound so Python 3.5 with branch-2.4 tests can pass too. ## Why are the changes needed? To make the CI build stable ## Does this PR introduce any user-facing change? No, dev-only change. ## How was this patch tested? Jenkins will test. Closes #28005 from HyukjinKwon/investigate-pip-packaging-followup. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 178d472) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Mar 26, 2020
…or setuptools in pip package test This PR is a followup of #27995. Rather then pining setuptools version, it sets upper bound so Python 3.5 with branch-2.4 tests can pass too. To make the CI build stable No, dev-only change. Jenkins will test. Closes #28005 from HyukjinKwon/investigate-pip-packaging-followup. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 178d472) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
Author
|
Okay, seems the new maintenence release isn't published to conda yet - https://anaconda.org/anaconda/setuptools. I will revert this change once it's available. |
Member
Author
|
This PR is rather to fix the ongoing pip test failure in branch-2.4, and reduce the diff between branches. I will revert appropriately once we can confirm the latest setuptools fixed this issue via running pip test in Jenkins machines later. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…or setuptools in pip package test ## What changes were proposed in this pull request? This PR is a followup of apache#27995. Rather then pining setuptools version, it sets upper bound so Python 3.5 with branch-2.4 tests can pass too. ## Why are the changes needed? To make the CI build stable ## Does this PR introduce any user-facing change? No, dev-only change. ## How was this patch tested? Jenkins will test. Closes apache#28005 from HyukjinKwon/investigate-pip-packaging-followup. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #27995. Rather then pining setuptools version, it sets upper bound so Python 3.5 with branch-2.4 tests can pass too.
Why are the changes needed?
To make the CI build stable
Does this PR introduce any user-facing change?
No, dev-only change.
How was this patch tested?
Jenkins will test.