[SPARK-31277][SQL][TESTS] Migrate DateTimeTestUtils from TimeZone to ZoneId
#28033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #120414 has finished for PR 28033 at commit
|
Member
Author
|
jenkins, retest this, please |
MaxGekk
changed the title
DateTimeTestUtils from TimeZone to ZoneIdDateTimeTestUtils from TimeZone to ZoneId
Member
Author
|
@cloud-fan @HyukjinKwon Please, have a look at the PR. |
|
Test build #120433 has finished for PR 28033 at commit
|
cloud-fan
reviewed
Mar 27, 2020
|
|
||
| val tz = LA.getId | ||
| withDefaultTimeZone(TimeZone.getTimeZone(tz)) { | ||
| withDefaultTimeZone(getZoneId(tz)) { |
cloud-fan
reviewed
Mar 27, 2020
| val UTC_OPT = Option("UTC") | ||
|
|
||
| val ALL_TIMEZONES: Seq[TimeZone] = TimeZone.getAvailableIDs.toSeq.map(TimeZone.getTimeZone) | ||
| val ALL_TIMEZONES: Seq[ZoneId] = ZoneId.getAvailableZoneIds.asScala.map(getZoneId).toSeq |
Contributor
There was a problem hiding this comment.
I'm wondering if we should only test the outstandingZoneIds instead of ALL_TIMEZONES. The test can be very slow if we test all timezones.
Member
Author
There was a problem hiding this comment.
We already discussed this some time ago, see #22657 . We replaced ALL_TIMEZONES by outstanding time zones in some places but decided to leave in date-time tests. @srowen proposed to run tests for ALL_TIMEZONES in parallel, see #22672 (#22672 (comment)). Total time of testing all time zone in parallel ~0.24 seconds. Not so much, I think.
|
Test build #120453 has finished for PR 28033 at commit
|
Member
Author
|
jenkins, retest this, please |
|
Test build #120464 has finished for PR 28033 at commit
|
Contributor
|
thanks, merging to master/3.0 ! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 27, 2020
… to `ZoneId` In the PR, I propose to change types of `DateTimeTestUtils` values and functions by replacing `java.util.TimeZone` to `java.time.ZoneId`. In particular: 1. Type of `ALL_TIMEZONES` is changed to `Seq[ZoneId]`. 2. Remove `val outstandingTimezones: Seq[TimeZone]`. 3. Change the type of the time zone parameter in `withDefaultTimeZone` to `ZoneId`. 4. Modify affected test suites. Currently, Spark SQL's date-time expressions and functions have been already ported on Java 8 time API but tests still use old time APIs. In particular, `DateTimeTestUtils` exposes functions that accept only TimeZone instances. This is inconvenient, and CPU consuming because need to convert TimeZone instances to ZoneId instances via strings (zone ids). No By affected test suites executed by jenkins builds. Closes #28033 from MaxGekk/with-default-time-zone. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 9f0c010) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
… to `ZoneId` ### What changes were proposed in this pull request? In the PR, I propose to change types of `DateTimeTestUtils` values and functions by replacing `java.util.TimeZone` to `java.time.ZoneId`. In particular: 1. Type of `ALL_TIMEZONES` is changed to `Seq[ZoneId]`. 2. Remove `val outstandingTimezones: Seq[TimeZone]`. 3. Change the type of the time zone parameter in `withDefaultTimeZone` to `ZoneId`. 4. Modify affected test suites. ### Why are the changes needed? Currently, Spark SQL's date-time expressions and functions have been already ported on Java 8 time API but tests still use old time APIs. In particular, `DateTimeTestUtils` exposes functions that accept only TimeZone instances. This is inconvenient, and CPU consuming because need to convert TimeZone instances to ZoneId instances via strings (zone ids). ### Does this PR introduce any user-facing change? No ### How was this patch tested? By affected test suites executed by jenkins builds. Closes apache#28033 from MaxGekk/with-default-time-zone. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to change types of
DateTimeTestUtilsvalues and functions by replacingjava.util.TimeZonetojava.time.ZoneId. In particular:ALL_TIMEZONESis changed toSeq[ZoneId].val outstandingTimezones: Seq[TimeZone].withDefaultTimeZonetoZoneId.Why are the changes needed?
Currently, Spark SQL's date-time expressions and functions have been already ported on Java 8 time API but tests still use old time APIs. In particular,
DateTimeTestUtilsexposes functions that accept only TimeZone instances. This is inconvenient, and CPU consuming because need to convert TimeZone instances to ZoneId instances via strings (zone ids).Does this PR introduce any user-facing change?
No
How was this patch tested?
By affected test suites executed by jenkins builds.