[SPARK-3944][Core] Code re-factored as suggested

[Shiti]

No description provided.

[AmplabJenkins]

Can one of the admins verify this patch?

[markhamstra]

ok to test

[vanzin]

Hi @Shiti , could you write a less cryptic PR title? This becomes the git commit summary, so it's recommended that it describe the actual change. Thanks!

[andrewor14]

add to whitelist

[andrewor14]

need spaces around |

[SparkQA]

QA tests have started for PR 2810 at commit 8ee1cc9.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2810 at commit 8ee1cc9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21777/
Test PASSed.

[SparkQA]

QA tests have started for PR 2810 at commit 051d82f.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2810 at commit 051d82f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21800/
Test PASSed.

[andrewor14]

@markhamstra does this LGTY?

[markhamstra]

Yup, LGTM. And as a general rule for the future, avoid pattern matching on Some and None. In most cases you should instead use a map, flatMap or foreach over the Option. Even, as in this instance, when you can't do that, matching on Some and None isn't good Scala style.

[andrewor14]

Alright, I'm merging this.