[SPARK-31327][SQL] Write Spark version into Avro file metadata #28102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #120725 has finished for PR 28102 at commit
|
MaxGekk
reviewed
Apr 2, 2020
external/avro/src/main/java/org/apache/spark/sql/avro/SparkAvroKeyOutputFormat.java
Show resolved
Hide resolved
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOutputWriter.scala
Show resolved
Hide resolved
Member
|
Thank you for pinging me, @cloud-fan . |
| this.mAvroFileWriter.create(writerSchema, outputStream); | ||
| } | ||
|
|
||
| public void write(AvroKey<T> record, NullWritable ignore) throws IOException { |
Member
There was a problem hiding this comment.
@cloud-fan . Do we need to check the effect in terms of performance because this is an additional wrapper technically? Oh, never mind.
external/avro/src/main/java/org/apache/spark/sql/avro/SparkAvroKeyOutputFormat.java
Show resolved
Hide resolved
|
Test build #120749 has finished for PR 28102 at commit
|
| class SparkAvroKeyRecordWriter<T> extends RecordWriter<AvroKey<T>, NullWritable> | ||
| implements Syncable { | ||
| private final DataFileWriter<T> mAvroFileWriter; | ||
| public SparkAvroKeyRecordWriter( |
Member
There was a problem hiding this comment.
Could you fix this?
/home/jenkins/workspace/SparkPullRequestBuilder@3/external/avro/src/main/java/org/apache/spark/sql/avro/SparkAvroKeyOutputFormat.java:65: Redundant 'public' modifier.
viirya
reviewed
Apr 3, 2020
| Map<String, String> metadata) throws IOException { | ||
| this.mAvroFileWriter = new DataFileWriter(dataModel.createDatumWriter(writerSchema)); | ||
| for (Map.Entry<String, String> entry : metadata.entrySet()) { | ||
| this.mAvroFileWriter.setMeta(entry.getKey(), entry.getValue()); |
Member
There was a problem hiding this comment.
Seems it is better to check if conflicting with reserved meta by isReservedMeta?
Contributor
Author
There was a problem hiding this comment.
It's already checked in the method setMeta.
HyukjinKwon
reviewed
Apr 3, 2020
| override def getDefaultWorkFile(context: TaskAttemptContext, extension: String): Path = { | ||
| new Path(path) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Shall we don't change this? Keeping a blank line between methods is actually a valid style (https://github.com/databricks/scala-style-guide#blank-lines-vertical-whitespace)
HyukjinKwon
approved these changes
Apr 3, 2020
|
Test build #120758 has finished for PR 28102 at commit
|
Contributor
Author
|
The last commit just adds blank lines. Thanks for the review, merging to master/3.0! |
cloud-fan
added a commit
that referenced
this pull request
Apr 3, 2020
### What changes were proposed in this pull request? Write Spark version into Avro file metadata ### Why are the changes needed? The version info is very useful for backward compatibility. This is also done in parquet/orc. ### Does this PR introduce any user-facing change? no ### How was this patch tested? new test Closes #28102 from cloud-fan/avro. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 6b1ca88) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
Test build #120769 has finished for PR 28102 at commit
|
cloud-fan
added a commit
to cloud-fan/spark
that referenced
this pull request
Apr 8, 2020
Write Spark version into Avro file metadata The version info is very useful for backward compatibility. This is also done in parquet/orc. no new test Closes apache#28102 from cloud-fan/avro. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
added a commit
to cloud-fan/spark
that referenced
this pull request
Apr 8, 2020
Write Spark version into Avro file metadata The version info is very useful for backward compatibility. This is also done in parquet/orc. no new test Closes apache#28102 from cloud-fan/avro. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? Write Spark version into Avro file metadata ### Why are the changes needed? The version info is very useful for backward compatibility. This is also done in parquet/orc. ### Does this PR introduce any user-facing change? no ### How was this patch tested? new test Closes apache#28102 from cloud-fan/avro. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Write Spark version into Avro file metadata
Why are the changes needed?
The version info is very useful for backward compatibility. This is also done in parquet/orc.
Does this PR introduce any user-facing change?
no
How was this patch tested?
new test