Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR fixes the added version of spark.sql.execution.pandas.udf.buffer.size to 3.0.0 (see also SPARK-27870)

Why are the changes needed?

To show the correct version added.

Does this PR introduce any user-facing change?

Yes but only in the unreleased branches. It will change the version shown in SQL documentation.

How was this patch tested?

Not tested. Jenkins will test it out.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Apr 7, 2020

This is the last PR if I didn't miss anything. It should be backported to branch-3.0 as well.

cc @beliefer, @cloud-fan, @dongjoon-hyun, @gatorsmile.

@HyukjinKwon
Copy link
Member Author

BTW, thanks for finding this instance @beliefer.

@HyukjinKwon
Copy link
Member Author

Thanks @srowen.

@HyukjinKwon
Copy link
Member Author

Let me merge this - build and documentation generation test passed, which are relevant with my change, really.

Merged to master and branch-3.0.

HyukjinKwon added a commit that referenced this pull request Apr 7, 2020
….pandas.udf.buffer.size to 3.0.0

### What changes were proposed in this pull request?

This PR fixes the added version of `spark.sql.execution.pandas.udf.buffer.size` to 3.0.0 (see also SPARK-27870)

### Why are the changes needed?

To show the correct version added.

### Does this PR introduce any user-facing change?

Yes but only in the unreleased branches. It will change the version shown in SQL documentation.

### How was this patch tested?

Not tested. Jenkins will test it out.

Closes #28144 from HyukjinKwon/SPARK-30841-followup.

Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit 6cf7336)
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@SparkQA
Copy link

SparkQA commented Apr 7, 2020

Test build #120911 has finished for PR 28144 at commit 5178edd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor

beliefer commented Apr 8, 2020

@HyukjinKwon I have a problem why we change version of spark.sql.execution.pandas.udf.buffer.size to 3.0.0? Because branch-3.0 not exists this config.
Although branch-3.0 have spark.sql.pandas.udf.buffer.size. I think the since version of spark.sql.execution.pandas.udf.buffer.size is still 3.1.0. Maybe I lost something.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Apr 8, 2020

@beliefer, thanks for pointing it out. It has to be spark.sql.execution.pandas.udf.buffer.size because it was renamed #27450 .I backported #27450 too.

@HyukjinKwon
Copy link
Member Author

@beliefer
Copy link
Contributor

beliefer commented Apr 8, 2020

@HyukjinKwon Thank you. The work of version statistics has finally come to an end.

sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
….pandas.udf.buffer.size to 3.0.0

### What changes were proposed in this pull request?

This PR fixes the added version of `spark.sql.execution.pandas.udf.buffer.size` to 3.0.0 (see also SPARK-27870)

### Why are the changes needed?

To show the correct version added.

### Does this PR introduce any user-facing change?

Yes but only in the unreleased branches. It will change the version shown in SQL documentation.

### How was this patch tested?

Not tested. Jenkins will test it out.

Closes apache#28144 from HyukjinKwon/SPARK-30841-followup.

Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@HyukjinKwon HyukjinKwon deleted the SPARK-30841-followup branch July 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants