Skip to content

[SPARK-31484][Core][Flollowup] Use taskAttemptId in checkpoint filename #28289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 1 commit into from
Closed

[SPARK-31484][Core][Flollowup] Use taskAttemptId in checkpoint filename #28289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,7 @@ private[spark] object ReliableCheckpointRDD extends Logging {

val finalOutputName = ReliableCheckpointRDD.checkpointFileName(ctx.partitionId())
val finalOutputPath = new Path(outputDir, finalOutputName)
val tempOutputPath = new Path(outputDir,
s".$finalOutputName-attempt-${ctx.stageAttemptNumber()}-${ctx.attemptNumber()}")
val tempOutputPath = new Path(outputDir, s".$finalOutputName-attempt-${ctx.taskAttemptId()}")
Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya. It looks simpler.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do we need -attempt-?

Copy link
Contributor

@cloud-fan cloud-fan Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

private[spark] class TaskDescription(
    val taskId: Long,
    val attemptNumber: Int,
...

I believe taskAttempId is some kind of historic name in TaskContext.


val bufferSize = env.conf.get(BUFFER_SIZE)

Expand Down