[SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan. #28355
Conversation
|
Test build #121860 has finished for PR 28355 at commit
|
| font-weight: bold; | ||
| } | ||
|
|
||
| #plan-viz-graph svg text { |
There was a problem hiding this comment.
Previously, we handled all .label. Now, this PR is about text.
If we start to consider text, are you sure that this is the last text?
There was a problem hiding this comment.
I think we need to consider three part of DAG-viz. Stages, RDDs and query plans.
In the previous PR, I changed the color of .label for stages and RDDs. Both are covered here.
I also changed color of .label for query plans here.
About text, for stages and RDDs, it's already covered here.
So I think the last one is for query plans. It's covered by this PR.
There was a problem hiding this comment.
Thanks for the confirmation! Now, it's clear to me.
|
Retest this please. |
|
@sarutak . I checked the |
|
@dongjoon-hyun Thanks for checking. The appearance you mention is intentional so I've updated the description. |
|
Test build #121867 has finished for PR 28355 at commit
|
|
retest this please. |
|
Test build #121908 has finished for PR 28355 at commit
|
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @sarutak .
Merged to master/3.0.
…query plan ### What changes were proposed in this pull request? This PR adds a font color setting of DAG-viz for query plan. ### Why are the changes needed? #28352 aimed to unify the font color of all DAG-viz in WebUI but there is one part left over. Before this change applied, the appearance of a query plan is like as follows. <img width="456" alt="plan-graph-fixed" src="https://user-images.githubusercontent.com/4736016/80325600-ca4d4e00-8870-11ea-945c-64971dbb752c.png"> The color of `WholeStageCodegen (1)` and its following text (`duration: total...`) is slightly darker than `SerializeFromObject`. After this change, those color is unified as `#333333`. <img width="450" alt="plan-graph-fixed2" src="https://user-images.githubusercontent.com/4736016/80325651-fb2d8300-8870-11ea-8ed8-178c124d224c.png"> ### Does this PR introduce any user-facing change? Slightly yes. ### How was this patch tested? I confirmed the style of `fill` and `color` is `#333333` by debug console of Chrome. <img width="321" alt="fill" src="https://user-images.githubusercontent.com/4736016/80325760-6c6d3600-8871-11ea-82e7-e789bf741f2a.png"> <img width="316" alt="color" src="https://user-images.githubusercontent.com/4736016/80325765-70995380-8871-11ea-8976-7020205d585c.png"> Closes #28355 from sarutak/followup-SPARK-31565. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 7d4d05c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
3 participants
What changes were proposed in this pull request?
This PR adds a font color setting of DAG-viz for query plan.
Why are the changes needed?
#28352 aimed to unify the font color of all DAG-viz in WebUI but there is one part left over.
Before this change applied, the appearance of a query plan is like as follows.
The color of
WholeStageCodegen (1)and its following text (duration: total...) is slightly darker thanSerializeFromObject.After this change, those color is unified as
#333333.Does this PR introduce any user-facing change?
Slightly yes.
How was this patch tested?
I confirmed the style of
fillandcoloris#333333by debug console of Chrome.