[SPARK-3997][Build]scalastyle should output the error location

[witgo]

No description provided.

[SparkQA]

QA tests have started for PR 2846 at commit 82c38ec.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2846 at commit 82c38ec.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21886/
Test PASSed.

[srowen]

Why does this change affect the output, and what is the change? grep -e already prints the whole line that matched. Why change the scalastyle settings too? This has merge conflicts too.

[witgo]

scalastyle-sbt-plugin 0.5 output [error] /Users/witgo/work/code/java/spark/mllib/src/main/scala/org/apache/spark/mllib/feature/TopicModeling.scala:413: line.size.limit.message
scalastyle-sbt-plugin 0.6 output [error] /Users/witgo/work/code/java/spark/mllib/src/main/scala/org/apache/spark/mllib/feature/TopicModeling.scala:413: File line length exceeds 100 characters
grep -e "\<error\>" is not match these.

And scalastyle-sbt-plugin 0.5 output line.size.limit.message is incorrect

[SparkQA]

Test build #22141 has started for PR 2846 at commit d6a57f8.

• This patch merges cleanly.

[SparkQA]

Test build #22141 has finished for PR 2846 at commit d6a57f8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22141/
Test PASSed.

[ScrapCodes]

Why scala style settings is removed ? is it no longer needed ?

[witgo]

Yes, this class has been removed. see Plugin.scala

[JoshRosen]

LGTM; I'm going to merge this so that Jenkins gives useful output for style errors.

[srowen]

The awk command here is still a little wrong, as it matches any string error. grep "\[error\]" definitely works on scalastyle.txt to match [error]. There's a confusion here somewhere but hey this may end up working just fine to look for error only, and awk is probably installed everywhere, just suboptimal.

[witgo]

cat scalastyle.txt | grep '\e\[0m\[\e\[31merror\e\[0m\]'is ok.