Skip to content

[SPARK-31874][SQL] Use FastDateFormat as the legacy fractional formatter #28678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 1 commit into from
Closed

[SPARK-31874][SQL] Use FastDateFormat as the legacy fractional formatter #28678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ class FractionTimestampFormatter(zoneId: ZoneId)
TimestampFormatter.defaultPattern,
zoneId,
TimestampFormatter.defaultLocale,
LegacyDateFormats.FAST_DATE_FORMAT,
Copy link
Contributor

@cloud-fan cloud-fan May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it the same with Spark 2.4?

Copy link
Member Author

@MaxGekk MaxGekk May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spark 2.4 uses SimpleDateFormat but output of FastDateFormat and SimpleDateFormat for the concrete pattern yyyy-MM-dd HH:mm:ss is the same. At least, all our tests show no difference.

needVarLengthSecondFraction = false) {

@transient
Expand Down Expand Up @@ -224,7 +225,11 @@ class LegacyFastTimestampFormatter(
}

override def format(ts: Timestamp): String = {
format(fromJavaTimestamp(ts))
if (ts.getNanos == 0) {
fastDateFormat.format(ts)
} else {
format(fromJavaTimestamp(ts))
}
}

override def format(instant: Instant): String = {
Expand Down