[SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input #28956
Conversation
| } | ||
| } | ||
|
|
||
| test("SPARK-31710:Adds TIMESTAMP_SECONDS, " + |
There was a problem hiding this comment.
This test is rewritten to increase test coverage.
|
Test build #124646 has finished for PR 28956 at commit
|
| extends NumberToTimestampBase { | ||
| // scalastyle:on line.size.limit | ||
| case class SecondsToTimestamp(child: Expression) extends UnaryExpression | ||
| with ExpectsInputTypes with NullIntolerant{ |
There was a problem hiding this comment.
nit: NullIntolerant{ -> NullIntolerant {.
|
|
||
| -- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer | ||
| select TIMESTAMP_SECONDS(1230219000),TIMESTAMP_SECONDS(-1230219000),TIMESTAMP_SECONDS(null); | ||
| select TIMESTAMP_SECONDS(1.23), TIMESTAMP_SECONDS(1.23d); |
There was a problem hiding this comment.
Since this has Decimal and Double, can we have Float together by using TIMESTAMP_SECONDS(CAST(1.23 AS FLOAT))?
| select TIMESTAMP_MILLIS(92233720368547758); | ||
| select TIMESTAMP_MILLIS(-92233720368547758); | ||
| -- truncate exception | ||
| select TIMESTAMP_SECONDS(0.1234567); |
There was a problem hiding this comment.
Shall we have a test case for allow truncation together because this PR allows truncation for double type?
There was a problem hiding this comment.
This PR aims to allow truncation for both ANSI and legacy mode. Did I understand correctly?
There was a problem hiding this comment.
yes, float/double are approximate values and truncation should be always allowed.
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for updating, @cloud-fan .
|
Test build #124747 has finished for PR 28956 at commit
|
|
Merged to master for Apache Spark 3.1.0. |
|
+1 looks good to me too. |
4 participants
What changes were proposed in this pull request?
This is a followup of #28534 , to make
TIMESTAMP_SECONDSfunction support fractional input as well.Why are the changes needed?
Previously the cast function can cast fractional values to timestamp. Now we suggest users to ues these new functions, and we need to cover all the cast use cases.
Does this PR introduce any user-facing change?
Yes, now
TIMESTAMP_SECONDSfunction accepts fractional input.How was this patch tested?
new tests