Skip to content

[SPARK-32058][BUILD][SQL][test-hive1.2][test-hadoop2.7][FOLLOWUP] Set hadoop 2.7.4 for hive 1.2 profile #29006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 3 commits into from
Closed

[SPARK-32058][BUILD][SQL][test-hive1.2][test-hadoop2.7][FOLLOWUP] Set hadoop 2.7.4 for hive 1.2 profile #29006

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
885cf7a
[SPARK-32058][BUILD][SQL][test-hive1.2][FOLLOWUP] Set hadoop 2.7.4 fo…
yaooqinn Jul 6, 2020
5fed5a2
test
yaooqinn Jul 6, 2020
e1db207
use maven-enforcer
yaooqinn Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3085,6 +3085,31 @@
<orc.classifier>nohive</orc.classifier>
<datanucleus-core.version>3.2.10</datanucleus-core.version>
</properties>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-hadoop-versions</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<bannedDependencies>
<excludes>
<exclude>org.apache.hadoop:*:[3.2.0,)</exclude>
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work in sbt run? It seems that PR builder is banned by this.

[info] Building Spark using SBT with these arguments:  -Phadoop-2.7 -Phive-1.2 -Pspark-ganglia-lgpl -Pyarn -Pkubernetes -Phadoop-cloud -Phive-thriftserver -Phive -Pkinesis-asl -Pmesos test:package streaming-kinesis-asl-assembly/assembly

Copy link
Member Author

@yaooqinn yaooqinn Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work for sbt runner, and I don't know how to enable this for it. Any advice？

Copy link
Member

@HyukjinKwon HyukjinKwon Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just drop this PR then. We'll deprecate and remove Hive 1.2 profile in the near future anyway.

Copy link
Member Author

@yaooqinn yaooqinn Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll close this

</excludes>
</bannedDependencies>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<profile>
Expand Down